Skip to content

CNF-6357: feat: add CPU Partitioning flag into the install config #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Feb 10, 2023
Merged

CNF-6357: feat: add CPU Partitioning flag into the install config #6430

openshift-merge-robot merged 3 commits into from
Feb 10, 2023

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Sep 29, 2022

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch 2 times, most recently from 64d0308 to 1f3a7ff Compare September 30, 2022 16:28
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Sep 30, 2022

Hey @patrickdillon while we wait for the API PR to go through, does this implementation make sense now, I removed the MCs and this just includes the addition of the new flag for CPU Partitioning.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022
@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch from 1f3a7ff to 2a35318 Compare October 1, 2022 01:32
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 4, 2022

/cc @rphillips @mrunalp

@openshift-ci openshift-ci bot requested review from mrunalp and rphillips October 4, 2022 17:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch from 2a35318 to eaec556 Compare October 12, 2022 21:14
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch from eaec556 to 401b7ef Compare January 18, 2023 18:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 6, 2023

/assign @rna-afk

This PR is the one that implements the installer flag for openshift/enhancements#1213 , we're waiting on getting the API change in, hopefully by end of the week we'll get QE sign off on the API addition to unblock this PR.

@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch 2 times, most recently from eef1286 to cf15e3d Compare February 8, 2023 16:50
@eggfoobar eggfoobar force-pushed the feat_support_cpu_partitioning branch from cf15e3d to c4824a4 Compare February 8, 2023 19:27
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 8, 2023

/unhold
/test golint

@rna-afk This should be all set for a review when you get a chance.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@rna-afk
Copy link
Contributor

rna-afk commented Feb 8, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn eaec556c06f95b3a25acaba315d6584828bce49d link true /test e2e-gcp-ovn
ci/prow/e2e-ibmcloud-ovn eaec556c06f95b3a25acaba315d6584828bce49d link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack eaec556c06f95b3a25acaba315d6584828bce49d link false /test e2e-openstack
ci/prow/e2e-libvirt eaec556c06f95b3a25acaba315d6584828bce49d link false /test e2e-libvirt
ci/prow/e2e-metal-assisted eaec556c06f95b3a25acaba315d6584828bce49d link false /test e2e-metal-assisted
ci/prow/e2e-vsphere-ovn eaec556c06f95b3a25acaba315d6584828bce49d link true /test e2e-vsphere-ovn
ci/prow/agent-integration-tests eaec556c06f95b3a25acaba315d6584828bce49d link true /test agent-integration-tests
ci/prow/okd-e2e-aws-ovn-upgrade c4824a4 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-workers-rhel8 c4824a4 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-disruptive c4824a4 link false /test e2e-aws-ovn-disruptive
ci/prow/okd-scos-e2e-aws-upgrade c4824a4 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn c4824a4 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 9, 2023

/cc @rphillips When you get a chance can you give this a once over?

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 9, 2023

/retest-required

@rphillips
Copy link
Contributor

rphillips commented Feb 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit b7a2a81 into openshift:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@rphillips rphillips

@rna-afk rna-afk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eggfoobar @rna-afk @rphillips @openshift-merge-robot