Skip to content

Power VS: Disconnected cluster support #6347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 7, 2022
Merged

Power VS: Disconnected cluster support #6347

openshift-merge-robot merged 2 commits into from
Oct 7, 2022

Conversation

@mjturek
Copy link
Contributor

@mjturek mjturek commented Sep 14, 2022

Installer side changes needed to enable disconnected cluster support for the Power VS provider.

Depends-on: #6228

@mjturek mjturek changed the title Disconnected cluster support Power VS: Disconnected cluster support Sep 14, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@mjturek mjturek force-pushed the disconnected-cluster-support branch from 0945f3f to 6636fd4 Compare September 26, 2022 17:56
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2022
@mjturek mjturek force-pushed the disconnected-cluster-support branch 17 times, most recently from b927e1a to 8624eef Compare September 29, 2022 17:05
@mjturek
Copy link
Contributor Author

mjturek commented Sep 29, 2022

/hold waiting for IBM Cloud team to confirm if provider bump is okay. @cjschaef @jeffnowicki let me know what you think. Thanks!

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@r4f4
Copy link
Contributor

r4f4 commented Sep 29, 2022

/test yaml-lint

@r4f4
Copy link
Contributor

r4f4 commented Sep 29, 2022

/test okd-unit

@mjturek mjturek force-pushed the disconnected-cluster-support branch 3 times, most recently from 0a81212 to b35dde7 Compare September 30, 2022 21:34
@r4f4 r4f4 removed their assignment Oct 5, 2022
@r4f4
Copy link
Contributor

r4f4 commented Oct 5, 2022

/assign @rna-afk

@mjturek
Copy link
Contributor Author

mjturek commented Oct 6, 2022

@jstuever would appreciate your review here. Trying to land this for feature complete.

@mjturek
Copy link
Contributor Author

mjturek commented Oct 6, 2022

/retest-required

@rna-afk
Copy link
Contributor

rna-afk commented Oct 6, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2022

/retest-required

Remaining retests: 0 against base HEAD 53727e6 and 2 for PR HEAD 3f1326c in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD 53727e6 and 2 for PR HEAD 3f1326c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD c100594 and 1 for PR HEAD 3f1326c in total

@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/skip

@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/override ci/prow/e2e-vsphere-ovn ci/prow/e2e-azure-ovn ci/prow/e2e-aws-ovn ci/prow/e2e-agent-compact ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-agent-compact, ci/prow/e2e-aws-ovn, ci/prow/e2e-azure-ovn, ci/prow/e2e-gcp-ovn, ci/prow/e2e-vsphere-ovn

Details

In response to this:

/override ci/prow/e2e-vsphere-ovn ci/prow/e2e-azure-ovn ci/prow/e2e-aws-ovn ci/prow/e2e-agent-compact ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD 7b739cd and 0 for PR HEAD 3f1326c in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/hold

Revision 3f1326c was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022
@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022
@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/skip

@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/override ci/prow/okd-scos-images ci/prow/okd-scos-unit ci/prow/okd-scos-verify-codegen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/okd-scos-images, ci/prow/okd-scos-unit, ci/prow/okd-scos-verify-codegen

Details

In response to this:

/override ci/prow/okd-scos-images ci/prow/okd-scos-unit ci/prow/okd-scos-verify-codegen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD 7b739cd and 2 for PR HEAD 3f1326c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022 •
edited
Loading

@mjturek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-ovn-upgrade b927e1a42826c2c4d083945edc18f3b066c42e2e link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/okd-e2e-aws-upgrade 3f1326c link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi 3f1326c link false /test e2e-metal-ipi
ci/prow/e2e-libvirt 3f1326c link false /test e2e-libvirt
ci/prow/okd-e2e-aws-ovn 3f1326c link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Oct 7, 2022

/override ci/prow/e2e-vsphere-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-vsphere-ovn

Details

In response to this:

/override ci/prow/e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bb20681 into openshift:master Oct 7, 2022
patrickdillon pushed a commit to patrickdillon/installer that referenced this pull request Oct 24, 2023
@openshift-merge-robot
Merge pull request openshift#6347 from mjturek/disconnected-cluster-s…
8c328a1 
…upport

Power VS: Disconnected cluster support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@Prashanth684 Prashanth684 Awaiting requested review from Prashanth684

2 more reviewers

@r4f4 r4f4 r4f4 left review comments

@miyamotoh miyamotoh miyamotoh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rna-afk rna-afk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mjturek @r4f4 @cjschaef @rna-afk @openshift-ci-robot @miyamotoh @openshift-merge-robot