Skip to content

add bind config for PowerVS publish==internal IPI #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 6, 2022
Merged

add bind config for PowerVS publish==internal IPI #6227

openshift-merge-robot merged 1 commit into from
Sep 6, 2022

Conversation

@miyamotoh
Copy link
Contributor

@miyamotoh miyamotoh commented Aug 15, 2022 •
edited
Loading

This PR is to add bind config (/etc/named.conf) for forwarding DNS queries to the private DNS service when publish==Internal for IPI in PowerVS. This also assumes the "proxy VM" is created and SSH access enabled via #6157.

Essentially, this runs a .sed file to edit the default named.conf file with necessary changes so the bind listens to the right ports and forwards queries to the private DNS service where the custom zone and entries will be configured at a later point. The name servers' addresses are hardcoded as publicly documented at: https://cloud.ibm.com/docs/dns-svcs?topic=dns-svcs-getting-started#step-3-add-vpc-as-permitted-network-to-dns-zone

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2022
@mjturek mjturek mentioned this pull request Aug 25, 2022
Merged
@miyamotoh miyamotoh changed the title [WIP] add bind config for PowerVS publish==internal IPI add bind config for PowerVS publish==internal IPI Aug 26, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@mjturek
Copy link
Contributor

mjturek commented Aug 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@miyamotoh
Copy link
Contributor Author

miyamotoh commented Aug 30, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere 6b819e47f01de55920a0d65d35bcef2717886ac9 link true /test e2e-vsphere
ci/prow/e2e-openstack 6b819e47f01de55920a0d65d35bcef2717886ac9 link false /test e2e-openstack
ci/prow/e2e-libvirt 6b819e47f01de55920a0d65d35bcef2717886ac9 link false /test e2e-libvirt
ci/prow/e2e-azure 6b819e47f01de55920a0d65d35bcef2717886ac9 link true /test e2e-azure
ci/prow/e2e-ibmcloud 6b819e47f01de55920a0d65d35bcef2717886ac9 link false /test e2e-ibmcloud
ci/prow/okd-e2e-aws-ovn e0d0c02 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miyamotoh
Copy link
Contributor Author

miyamotoh commented Aug 31, 2022

/retest-required

@miyamotoh
Copy link
Contributor Author

miyamotoh commented Aug 31, 2022

@rna-afk could you review/approve?

@mjturek
Copy link
Contributor

mjturek commented Sep 1, 2022

@jstuever could you take a look?

@rna-afk
Copy link
Contributor

rna-afk commented Sep 6, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit b8714c6 into openshift:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mjturek mjturek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miyamotoh @mjturek @rna-afk @openshift-merge-robot