gcp: Add validation for Network Project Data #6207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
barbacbd
force-pushed
the
network_project_validation
branch
from
7367b8b to
f5ee0f6
Compare
barbacbd
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
|
/retest |
barbacbd
force-pushed
the
network_project_validation
branch
from
f5ee0f6 to
11974fe
Compare
openshift-merge-robot
added
the
needs-rebase
barbacbd
force-pushed
the
network_project_validation
branch
from
11974fe to
ee7cb98
Compare
openshift-merge-robot
removed
the
needs-rebase
** Added checks in types to ensure that network, computeSubnet, and controlPlaneSubnet are set when NetworkProjectID exists. ** Added checks in installconfig to ensure that CredentialsMode is set to either Passthrough or Manual when NetworkProjectID exists. CORS-2048 Requires openshift#6166 Removed Duplicated networkProjectID
barbacbd
force-pushed
the
network_project_validation
branch
from
ee7cb98 to
2f93c42
Compare
Contributor
|
/lgtm |
Contributor
Author
|
/test okd-images |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
Author
|
/retest |
Contributor
Contributor
Contributor
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Added checks in types to ensure that network, computeSubnet, and controlPlaneSubnet
are set when NetworkProjectID exists.
** Added checks in installconfig to ensure that CredentialsMode is set to either Passthrough or
Manual when NetworkProjectID exists.
CORS-2048
Requires #6166