chore(upi-aws): Add tag:Name to resources created by CloudFormation VPC stack template. #6088
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
mtulio
force-pushed
the
feat-upi-aws-cfn-vpc
branch
from
080a0b6 to
c4bcbb2
Compare
mtulio
force-pushed
the
feat-upi-aws-cfn-vpc
branch
2 times, most recently
from
66ff668 to
5ad0d04
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mtulio
force-pushed
the
feat-upi-aws-cfn-vpc
branch
from
5ad0d04 to
a1baa61
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @patrickdillon ptal? |
Create tag:Name for all resources created by VPC Stack. The resource ID PublicRouteTableId and PrivateRouteTableId are also being exported to be used in any external automation that may need this information - example: creating new stacks for other purposes like subnets in edge locations (Local Zones, etc)
mtulio
force-pushed
the
feat-upi-aws-cfn-vpc
branch
from
a1baa61 to
ce2a44d
Compare
mtulio
changed the title
|
/retest ci/prow/yaml-lint |
|
@mtulio: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mtulio
changed the title
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1 participant
Suggestion to create tags* on network resources created by CloudFormation templates on UPI installations.
*Tags suggested to be created:
Name=$ClusterName-<resource_name>Documentation reference that could be also updated:
That change should not impact in the existing flow/installations unless there is any check waiting for untagged resources.
Finally, the Route table ID (Public and Private) will be exported as output to be used (it will be used on CloudFormation templates to create Local Zone subnets).