asset/ignition: fix bootkube and tectonic retries #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 54242f8, RemainAfterExit was added to prevent bootkube.service and tectonic.service from running multiple times when progress.service restarted. Due to a systemd bug [1], this causes the restart to be ignored on those services. This new approach uses conditions instead. This allows systemd to activate the services but not actually start them if they have already completed. [1]: systemd/systemd#3396
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
Member
|
/lgtm Why is getting this right so difficult? 🤔 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 54242f8, RemainAfterExit was added to prevent bootkube.service
and tectonic.service from running multiple times when progress.service
restarted. Due to a systemd bug 1, this causes the restart to be
ignored on those services.
This new approach uses conditions instead. This allows systemd to
activate the services but not actually start them if they have already
completed.