Power VS: Separating bootstrap resources to own stage for clean destroy

[miyamotoh]

As eluded to in #5780, this is to move the bootstrap resource creation to its own TF stage so it can be called for quick terraform destory after bootstrap-complete for PowerVS platform. Also introduced is the bootstrap-routing stage which takes care of the necessary network routing components that live beyond the bootstrap phase, but need adjustments when bootstrap VM is around and gone.

Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com

[patrickdillon]

@miyamotoh required tf-fmt test is failing

[clnperez]

/lgtm

my only comment is that, the name bootstrap-routing is a bit confusing (to me at least) b/c it seems to imply that the things from this phase will be deleted, so i'd like to see it renamed to something like loadbalancers. but that's just a nit and we can update it later

[patrickdillon]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[miyamotoh]

/retest-required

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted	0e4da38	link	false	/test e2e-metal-assisted
ci/prow/okd-e2e-aws	0e4da38	link	false	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Prashanth684]

/lgtm

my only comment is that, the name bootstrap-routing is a bit confusing (to me at least) b/c it seems to imply that the things from this phase will be deleted, so i'd like to see it renamed to something like loadbalancers. but that's just a nit and we can update it later

maybe call it post-bootstrap like gcp does

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.