-
Notifications
You must be signed in to change notification settings - Fork 1.5k
data/bootstrap/files/usr/local/bin/bootkube: --rm all Podman containers #5803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/bootstrap/files/usr/local/bin/bootkube: --rm all Podman containers #5803
Conversation
Avoid [1]: Error: error creating container storage: the container name "mco-render" is already in use by "877829c1add4c25f797255405478c4b8f75da308bc5cb3037e171487eec0ff37". You have to remove that container to be able to reuse that name.: that name is already in use and similar for other containers by removing inconsistent --rm options and baking that in at the bootkube_podman_run level. Also add an etcd-bootstrap rm call, to clear out any cruft from a previous bootkube round before calling Podman for a fresh etcd render. [1]: openshift#5800 (comment)
|
/lgtm Looks straight forward to me! ;-) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Avoid:
and similar for other containers by removing inconsistent
--rmoptions and baking that in at thebootkube_podman_runlevel.Also add an
etcd-bootstraprmcall, to clear out any cruft from a previous bootkube round before calling Podman for a fresh etcd render.Spun out of #5800 as a hopefully straightforward, small robustness improvement.