Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 13, 2022

Avoid:

Error: error creating container storage: the container name "mco-render" is already in use by "877829c1add4c25f797255405478c4b8f75da308bc5cb3037e171487eec0ff37". You have to remove that container to be able to reuse that name.: that name is already in use

and similar for other containers by removing inconsistent --rm options and baking that in at the bootkube_podman_run level.

Also add an etcd-bootstrap rm call, to clear out any cruft from a previous bootkube round before calling Podman for a fresh etcd render.

Spun out of #5800 as a hopefully straightforward, small robustness improvement.

Avoid [1]:

  Error: error creating container storage: the container name "mco-render" is already in use by "877829c1add4c25f797255405478c4b8f75da308bc5cb3037e171487eec0ff37". You have to remove that container to be able to reuse that name.: that name is already in use

and similar for other containers by removing inconsistent --rm options
and baking that in at the bootkube_podman_run level.

Also add an etcd-bootstrap rm call, to clear out any cruft from a
previous bootkube round before calling Podman for a fresh etcd render.

[1]: openshift#5800 (comment)
@openshift-ci openshift-ci bot requested review from AnnaZivkovic and barbacbd April 13, 2022 04:13
@jhixson74
Copy link
Member

jhixson74 commented Apr 18, 2022

/lgtm

Looks straight forward to me! ;-)

@jhixson74
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@jhixson74
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-alibaba a42691f link false /test e2e-alibaba
ci/prow/e2e-aws-proxy a42691f link false /test e2e-aws-proxy
ci/prow/e2e-openstack a42691f link false /test e2e-openstack
ci/prow/e2e-crc a42691f link false /test e2e-crc
ci/prow/e2e-ibmcloud a42691f link false /test e2e-ibmcloud
ci/prow/e2e-azure-resourcegroup a42691f link false /test e2e-azure-resourcegroup
ci/prow/e2e-openstack-parallel a42691f link false /test e2e-openstack-parallel
ci/prow/e2e-libvirt a42691f link false /test e2e-libvirt
ci/prow/e2e-gcp-upi-xpn a42691f link false /test e2e-gcp-upi-xpn
ci/prow/e2e-aws-disruptive a42691f link false /test e2e-aws-disruptive
ci/prow/e2e-azurestack a42691f link false /test e2e-azurestack
ci/prow/e2e-aws-single-node a42691f link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 307439e into openshift:master Apr 21, 2022
@wking wking deleted the remove-podman-containers branch April 21, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants