Skip to content

Conversation

@cgwalters
Copy link
Member

Depends: openshift/machine-config-operator#3017

I want to add a new image (e.g. rhel-coreos as part of layering)
and this will avoid a tedious "ratching" process to plumb that
through the installer. Now the MCO can just directly read the image
references.

Depends: openshift/machine-config-operator#3017

I want to add a new image (e.g. `rhel-coreos` as part of layering)
and this will avoid a tedious "ratching" process to plumb that
through the installer.  Now the MCO can just directly read the image
references.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstuever after the PR has been reviewed.
You can assign the PR to them by writing /assign @jstuever in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

(Draft since this is not tested yet, also this is a good time to object or propose a different plan)

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable approach to me. I like the idea of pushing the domain knowledge of which images MCO is using to the MCO repo, instead of having it in the installer repo.

@jstuever
Copy link
Contributor

/cc @patrickdillon
/uncc

@openshift-ci openshift-ci bot requested review from patrickdillon and removed request for jstuever and kirankt October 12, 2022 16:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade 7991895 link true /test e2e-aws-upgrade
ci/prow/e2e-gcp-upgrade 7991895 link true /test e2e-gcp-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 7991895 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/openstack-manifests 7991895 link true /test openstack-manifests
ci/prow/e2e-aws-upi 7991895 link true /test e2e-aws-upi
ci/prow/e2e-azure-upi 7991895 link true /test e2e-azure-upi
ci/prow/e2e-gcp-upi 7991895 link true /test e2e-gcp-upi
ci/prow/e2e-vsphere 7991895 link true /test e2e-vsphere
ci/prow/e2e-azure 7991895 link true /test e2e-azure
ci/prow/e2e-gcp 7991895 link true /test e2e-gcp
ci/prow/e2e-aws 7991895 link true /test e2e-aws
ci/prow/e2e-vsphere-ovn 7991895 link true /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn 7991895 link true /test e2e-azure-ovn
ci/prow/e2e-aws-ovn 7991895 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-ovn 7991895 link true /test e2e-gcp-ovn
ci/prow/okd-scos-unit 7991895 link true /test okd-scos-unit
ci/prow/okd-scos-images 7991895 link true /test okd-scos-images
ci/prow/okd-scos-verify-codegen 7991895 link true /test okd-scos-verify-codegen
ci/prow/e2e-agent-compact-ipv4 7991895 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/close

in favor of #6234

@openshift-ci openshift-ci bot closed this Dec 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

@patrickdillon: Closed this PR.

Details

In response to this:

/close

in favor of #6234

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants