Skip to content

Conversation

@bd233
Copy link
Contributor

@bd233 bd233 commented Feb 24, 2022

If a user created cluster uses an existing privatezone, the private zone records should also be deleted when the cluster is destroyed.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@bd233: This pull request references Bugzilla bug 2048028, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2048028: [Alibaba] fix the deletion of private zone records

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

@patrickdillon: This pull request references Bugzilla bug 2048028, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei March 1, 2022 17:26
@bd233 bd233 force-pushed the fix-delete-record branch from 2778dac to 55b30dc Compare March 3, 2022 10:27
@jianli-wei
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 6, 2022
@sadasu
Copy link
Contributor

sadasu commented Sep 12, 2022

/test openstack-manifests

@sadasu
Copy link
Contributor

sadasu commented Sep 12, 2022

/test e2e-alibaba

@sadasu
Copy link
Contributor

sadasu commented Sep 16, 2022

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Sep 19, 2022

@bd233 are the e2e-alibaba failures related to this change?

@sadasu
Copy link
Contributor

sadasu commented Sep 19, 2022

/retest

If a user created cluster uses an existing privatezone,
the private zone records should also be deleted when the cluster is
 destroyed

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
@bd233
Copy link
Contributor Author

bd233 commented Sep 30, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval by writing /assign @rna-afk in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bd233
Copy link
Contributor Author

bd233 commented Oct 8, 2022

/test e2e-alibaba

@bd233
Copy link
Contributor Author

bd233 commented Oct 9, 2022

@bd233 are the e2e-alibaba failures related to this change?

@sadasu Do you know what this test e2e-alibaba is about, I got the same error on other PRs:

@sadasu
Copy link
Contributor

sadasu commented Oct 18, 2022

/retest-required

@r4f4
Copy link
Contributor

r4f4 commented Oct 18, 2022

/test e2e-alibaba

@r4f4
Copy link
Contributor

r4f4 commented Oct 19, 2022

@bd233 are the e2e-alibaba failures related to this change?

@sadasu Do you know what this test e2e-alibaba is about, I got the same error on other PRs:

* [5668](https://github.com/openshift/installer/pull/5668)

* [5671](https://github.com/openshift/installer/pull/5671)

* [6179](https://github.com/openshift/installer/pull/6179)

It's an IPI installation of OCP on Alibaba + e2e tests. But the issue is that we don't even reach the e2e tests because bootstrap fails to complete. The kubelet logs of the control plane nodes are full of

Oct 19 01:45:05 ci-op-s9bt145y-920ba-92jsm-master-1 kubenswrapper[2056]: E1019 01:45:05.566052    2056 kubelet.go:2396] "Container runtime network not ready" networkReady="NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?"

@sdodson
Copy link
Member

sdodson commented Jan 4, 2023

/test e2e-alibaba

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@bd233: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test e2e-aws-single-node
ci/prow/e2e-ibmcloud 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test e2e-ibmcloud
ci/prow/okd-e2e-aws 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test okd-e2e-aws
ci/prow/e2e-aws-upi 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-aws-upi
ci/prow/e2e-gcp-upi 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-gcp-upi
ci/prow/e2e-azure-upi 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-azure-upi
ci/prow/e2e-aws 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-aws
ci/prow/e2e-azure 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-azure
ci/prow/e2e-gcp 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-gcp
ci/prow/e2e-vsphere 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link true /test e2e-vsphere
ci/prow/okd-e2e-aws-upgrade 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-libvirt 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test e2e-libvirt
ci/prow/okd-e2e-aws-ovn 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-gcp-ovn-upgrade 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/e2e-crc 55b30dc7b8ae412e0ec3ca316e543e09852ac4f3 link false /test e2e-crc
ci/prow/okd-scos-unit e605744 link true /test okd-scos-unit
ci/prow/okd-scos-verify-codegen e605744 link true /test okd-scos-verify-codegen
ci/prow/e2e-alibaba e605744 link false /test e2e-alibaba

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2023
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants