Skip to content

Add Nutanix-specific customizations to manifests #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 30, 2022
Merged

Add Nutanix-specific customizations to manifests #5631

openshift-merge-robot merged 1 commit into from
Mar 30, 2022

Conversation

@thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Feb 10, 2022

  • Update templates in data/data/manifests
  • Add nutanix platform customizations in pkg/asset/manifests

@openshift-ci openshift-ci bot requested review from jstuever and rna-afk February 10, 2022 14:52
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@thunderboltsid thunderboltsid force-pushed the ntnx-3.1 branch 2 times, most recently from 8af2bf7 to 03bc38d Compare March 16, 2022 13:58
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 16, 2022

/retest-required

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 16, 2022

/test all

1 similar comment
@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 16, 2022

/test all

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 17, 2022

/retest-required

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 17, 2022

/assign @patrickdillon

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 17, 2022

/assign @staebler

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 17, 2022

/unassign @patrickdillon

staebler
staebler reviewed Mar 17, 2022
View reviewed changes
pkg/asset/manifests/cloudproviderconfig.go Outdated
Copy link
Contributor

@staebler staebler Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit surprised that there is not a cloud provider config. Is the name of the secret with the creds hard-coded somewhere?

Copy link
Contributor Author

@thunderboltsid thunderboltsid Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, yes. nutanix-credentials is the credential name.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
rvanderp3
rvanderp3 reviewed Mar 18, 2022
View reviewed changes
@thunderboltsid
Add Nutanix-specific customizations to manifests
b146798 
- Update templates in data/data/manifests
- Add nutanix platform customizations in pkg/asset/manifests
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 19, 2022

/retest-required

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 22, 2022

/lgtm

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 28, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 28, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 28, 2022

/retest-required

1 similar comment
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 29, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 29, 2022

/retest-required

1 similar comment
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 29, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022 •
edited
Loading

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-upi-xpn b146798 link false /test e2e-gcp-upi-xpn
ci/prow/e2e-ibmcloud b146798 link false /test e2e-ibmcloud
ci/prow/e2e-aws-shared-vpc b146798 link false /test e2e-aws-shared-vpc
ci/prow/e2e-aws-disruptive b146798 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-fips b146798 link false /test e2e-aws-fips
ci/prow/e2e-azurestack b146798 link false /test e2e-azurestack
ci/prow/e2e-azure-upi b146798 link false /test e2e-azure-upi
ci/prow/e2e-azure b146798 link false /test e2e-azure
ci/prow/e2e-azure-shared-vpc b146798 link false /test e2e-azure-shared-vpc
ci/prow/e2e-alibaba b146798 link false /test e2e-alibaba
ci/prow/okd-e2e-aws-upgrade b146798 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-proxy b146798 link false /test e2e-aws-proxy
ci/prow/e2e-crc b146798 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6bc11a5 into openshift:master Mar 30, 2022
@thunderboltsid thunderboltsid deleted the ntnx-3.1 branch May 25, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@rna-afk rna-afk Awaiting requested review from rna-afk

2 more reviewers

@staebler staebler staebler left review comments

@rvanderp3 rvanderp3 rvanderp3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thunderboltsid @rvanderp3 @openshift-bot @makentenza @staebler @patrickdillon @openshift-merge-robot