-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Validate user selected capabilities #5629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @wking |
patrickdillon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, but left some comments, mostly nits.
pkg/types/installconfig.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase to set this commit back on top of the current #5605.
$ git --no-pager log --oneline --graph -6 origin/pr/5605 origin/pr/5629
* c3b26f3f1 (origin/pr/5629) Validate additional user-specified openshift component capabilities
* 3c7d85c76 Vendor the latest version of openshift/api which contains support for user-selectable capabilities
* 77dfc61e8 Add user-selectable capabilities api in the installconfig
| * 65d684eef (origin/pr/5605) Vendor the latest version of openshift/api which contains support for user-selectable capabilities
| * 0542412a1 Add user-selectable capabilities api in the installconfig
|/
* d436da243 Merge pull request #5640 from nutanix-cloud-native/update-owner-aliases
|\ Fix the explain print output to include capabilities
… user-selectable capabilities
|
/retest |
|
@kirankt: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this PR in favor of #5645 |
This is a follow up to #5605 and has a hard dependency on it.
This PR adds validation to the user-selectable capabilities api in the install-config.