Skip to content

Conversation

@kirankt
Copy link
Contributor

@kirankt kirankt commented Feb 9, 2022

This is a follow up to #5605 and has a hard dependency on it.

This PR adds validation to the user-selectable capabilities api in the install-config.

@kirankt kirankt changed the title Validate user selected caps Validate user selected capabilities Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign staebler after the PR has been reviewed.
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jhixson74 and rna-afk February 9, 2022 19:04
@kirankt
Copy link
Contributor Author

kirankt commented Feb 9, 2022

/cc @wking

@openshift-ci openshift-ci bot requested a review from wking February 9, 2022 20:46
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but left some comments, mostly nits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to set this commit back on top of the current #5605.

$ git --no-pager log --oneline --graph -6 origin/pr/5605 origin/pr/5629
* c3b26f3f1 (origin/pr/5629) Validate additional user-specified openshift component capabilities
* 3c7d85c76 Vendor the latest version of openshift/api which contains support for user-selectable capabilities
* 77dfc61e8 Add user-selectable capabilities api in the installconfig
| * 65d684eef (origin/pr/5605) Vendor the latest version of openshift/api which contains support for user-selectable capabilities
| * 0542412a1 Add user-selectable capabilities api in the installconfig
|/  
*   d436da243 Merge pull request #5640 from nutanix-cloud-native/update-owner-aliases
|\ 

@kirankt
Copy link
Contributor Author

kirankt commented Feb 21, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2022

@kirankt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 2da9e06ff13578f898100bfe558d04a903caee3f link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node 1287960 link false /test e2e-aws-single-node
ci/prow/e2e-ibmcloud 1287960 link false /test e2e-ibmcloud
ci/prow/okd-e2e-aws-upgrade 1287960 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-crc 1287960 link false /test e2e-crc
ci/prow/e2e-azure-upi 1287960 link false /test e2e-azure-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kirankt
Copy link
Contributor Author

kirankt commented Feb 24, 2022

Closing this PR in favor of #5645

@kirankt kirankt closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants