Skip to content

Add IBM Power VS: tf plugin for ibm presign#5613

Closed
clnperez wants to merge 1 commit intoopenshift:masterfrom
clnperez:new-tf-plugins
Closed

Add IBM Power VS: tf plugin for ibm presign#5613
clnperez wants to merge 1 commit intoopenshift:masterfrom
clnperez:new-tf-plugins

Conversation

@clnperez
Copy link
Copy Markdown
Contributor

@clnperez clnperez commented Feb 4, 2022

This plugin is needed in order to securely host the ignition config
files for bootstrap machines. It uses the COS offering from IBM Cloud,
which is s3-compatible.

For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736

Older discussions on some of the code here can be found in #5224

Authored-by: Manjunath Kumatagi mailto:mkumatag@in.ibm.com
Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

This plugin is needed in order to securely host the ignition config
files for bootstrap machines. It uses the COS offering from IBM Cloud,
which is s3-compatible.

For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736

Older discussions on some of the code here can be found in openshift#5224

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstuever after the PR has been reviewed.
You can assign the PR to them by writing /assign @jstuever in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 5, 2022

@clnperez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr 6216d52 link false /test e2e-openstack-kuryr
ci/prow/e2e-aws-workers-rhel7 6216d52 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-ibmcloud 6216d52 link false /test e2e-ibmcloud
ci/prow/e2e-aws-workers-rhel8 6216d52 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-metal-ipi-ovn-ipv6 6216d52 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-single-node 6216d52 link false /test e2e-aws-single-node
ci/prow/e2e-metal-single-node-live-iso 6216d52 link false /test e2e-metal-single-node-live-iso
ci/prow/okd-e2e-aws-upgrade 6216d52 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-crc 6216d52 link false /test e2e-crc
ci/prow/e2e-azure-upi 6216d52 link false /test e2e-azure-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clnperez
Copy link
Copy Markdown
Contributor Author

clnperez commented Mar 3, 2022

Since this is now in: #5507 -- we'll do what ibmcloud is doing for the bootstrap ignition config and won't need this.

see https://github.com/openshift/installer/blob/86003e9797ec1c9a1160c156944556f557f9d3a7/data/data/ibmcloud/bootstrap/main.tf#L34:L38

cc @mkumatag @mjturek

@clnperez clnperez closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants