update master ign file list to single master ign file #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SRV records for bootstrapping etcd using DNS. xref: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md#dns-discovery
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
approved
Contributor
Author
|
#526 openshift/machine-config-operator#143 merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Nov 28, 2018
Catching up with 4fbf790 (data/data: convert master ign list to single ign, 2018-10-26, openshift#553). Before this commit, building with a master count larger than one would yield: * libvirt_domain.master[1]: index 1 out of range for list libvirt_ignition.master.*.id (max 1) in: ${libvirt_ignition.master.*.id[count.index]}
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Dec 17, 2018
The typo snuck in in 4bfcd51 (asset: update master ign file list to single master ign file, 2018-10-26, openshift#553).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the terraform code and installer code to use single
master.ignas they don't have to be unique any more/cc @crawford @wking
/hold
The PRs that need be be merged in order for this to merge: