Bug 2039109: Fix image-customization-controller image pull failure

[hs0210]

startironic.sh itself is executed under the root user, so there is no need to use sudo. And using sudo leads to the loss of proxy env, which causes the failure of image-customization pull.

Before #5473 sudo has been used to run Ironic related containers, but no error was reported because the ironic image had been downloaded to the local beofre. But the image-customization container newly added by #5473 did not pull the image locally before, so it triggered this long-standing error.

This PR fix the first error in #5504

Signed-off-by: Hu Shuai [email protected]

[openshift-ci]

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtantsur]

/ok-to-test

[zaneb]

We'll need to open a bugzilla for this.

/label platform/baremetal
/approve

[zaneb]

We're also using sudo for some iptables commands, it wouldn't hurt to get rid of those as well so that we're less likely to repeat the error.

[hs0210]

We're also using sudo for some iptables commands, it wouldn't hurt to get rid of those as well so that we're less likely to repeat the error.

Done. I removed sudo from iptables commands.

[hs0210]

We'll need to open a bugzilla for this.

Understood, we will do.

[hs0210]

/retest

[hs0210]

We'll need to open a bugzilla for this.

@zaneb We have sent the bugzilla, PTAL.

[dtantsur]

/retitle Bug 2039109: Fix image-customization-controller image pull failure

[openshift-ci]

@hs0210: An error was encountered searching for bug 2039109 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

code 102: You are not authorized to access bug #2039109. Most likely the bug has been restricted for internal development processes and we cannot grant access. If you are a Red Hat customer with an active subscription, please visit the Red Hat Customer Portal for assistance with your issue If you are a Fedora Project user and require assistance, please consider using one of the mailing lists we host for the Fedora Project.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2039109: Fix image-customization-controller image pull failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtantsur]

@hs0210 as you can see from the bot, private bugzillas cannot be attached to pull requests. Could you please open it or file a public one with limited information? In the latter case, please update the title again.

[hs0210]

/bugzilla refresh

[openshift-ci]

@hs0210: This pull request references Bugzilla bug 2039109, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhjanders]

/bugzilla refresh

[openshift-ci]

@rhjanders: This pull request references Bugzilla bug 2039109, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtantsur]

/lgtm

[andfasano]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• data/data/bootstrap/baremetal/OWNERS [andfasano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[hs0210]

/retest

[openshift-ci]

@hs0210: All pull requests linked via external trackers have merged:

• openshift/installer#5513

Bugzilla bug 2039109 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2039109: Fix image-customization-controller image pull failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hs0210: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.