Skip to content

Bug 1965969: aws: Fix dns destroy logs#5494

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
squidboylan:aws_dns_destroy
Jan 8, 2022
Merged

Bug 1965969: aws: Fix dns destroy logs#5494
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
squidboylan:aws_dns_destroy

Conversation

@squidboylan
Copy link
Copy Markdown
Contributor

@squidboylan squidboylan commented Dec 16, 2021

No description provided.

@openshift-ci openshift-ci Bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Dec 16, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 16, 2021

@squidboylan: This pull request references Bugzilla bug 1965969, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

Details

In response to this:

Bug 1965969: aws: Fix dns destroy logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 16, 2021
@squidboylan squidboylan force-pushed the aws_dns_destroy branch 2 times, most recently from b03d535 to 1451c3d Compare December 16, 2021 20:40
staebler
staebler reviewed Dec 17, 2021
View reviewed changes
Comment thread pkg/destroy/aws/shared.go Outdated
@squidboylan squidboylan requested a review from staebler December 17, 2021 17:32
staebler
staebler reviewed Dec 17, 2021
View reviewed changes
Comment thread pkg/destroy/aws/shared.go Outdated
Comment thread pkg/destroy/aws/shared.go Outdated
Comment thread pkg/destroy/aws/shared.go Outdated
Comment thread pkg/destroy/aws/shared.go Outdated
Comment thread pkg/destroy/aws/shared.go Outdated
@squidboylan squidboylan requested a review from staebler January 7, 2022 17:02
staebler
staebler reviewed Jan 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 7, 2022 •
edited
Loading

@squidboylan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 38d2f62 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 38d2f62 link false /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws-upgrade 38d2f62 link false /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 28cfc83 into openshift:master Jan 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 8, 2022

@squidboylan: All pull requests linked via external trackers have merged:

Bugzilla bug 1965969 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1965969: aws: Fix dns destroy logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@squidboylan @openshift-bot @staebler @openshift-merge-robot