Skip to content

cvo: Rename the API object for CVOConfig to ClusterVersion #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 2, 2018
Merged

cvo: Rename the API object for CVOConfig to ClusterVersion #549

openshift-merge-robot merged 1 commit into from
Nov 2, 2018

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Oct 26, 2018 •
edited
Loading

Depends on openshift/cluster-version-operator#45

Update the override object to point to the new name for CVOConfig,
config.openshift.io ClusterVersion.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2018
This was referenced Oct 26, 2018
Closed
Merged
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 2, 2018

/test all

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2018 •
edited
Loading

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack e9cc6913faeae7aade0c2ce66900a106d79ca4df link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
cvo: Rename the API object for CVOConfig to ClusterVersion
4a84a4b 
Update the override object to point to the new name for CVOConfig,
`config.openshift.io` `ClusterVersion`.
@smarterclayton smarterclayton changed the title WIP: cvo: Rename the API object for CVOConfig to ClusterVersion cvo: Rename the API object for CVOConfig to ClusterVersion Nov 2, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2018
@wking
Copy link
Member

wking commented Nov 2, 2018

/lint

openshift-ci-robot
openshift-ci-robot reviewed Nov 2, 2018
View reviewed changes
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking: 1 warning.

Details

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Nov 2, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0d6145a into openshift:master Nov 2, 2018
@wking wking mentioned this pull request Nov 2, 2018
Merged
@abhinavdahiya abhinavdahiya mentioned this pull request Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@openshift-ci-robot openshift-ci-robot openshift-ci-robot left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smarterclayton @openshift-ci-robot @wking @abhinavdahiya @openshift-merge-robot