Skip to content

Add OpenStack to clustermetadata.go #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 27, 2018
Merged

Add OpenStack to clustermetadata.go #544

openshift-merge-robot merged 1 commit into from
Oct 27, 2018

Conversation

@hardys
Copy link

@hardys hardys commented Oct 26, 2018

This code was recently reworked in:

#493

Adding OpenStack here means the destroy bootstrap option will
work for OpenStack, which is a first step towards full destroy
support for the OpenStack platform.

Add OpenStack to clustermetadata.go
9fefd84 
This code was recently reworked in:

openshift#493

Adding OpenStack here means the destroy bootstrap option will
work for OpenStack, which is a first step towards full destroy
support for the OpenStack platform.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2018
wking
wking approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.lgtm

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2018
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 26, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 26, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Oct 26, 2018

e2e-aws:

level=fatal msg="Error executing openshift-install: RequestLimitExceeded: Request limit exceeded.\n\tstatus code: 503, request id: ea45e277-3ee0-431e-8d1f-4336d4df63e8"
2018/10/26 21:12:52 Container setup in pod e2e-aws failed, exit code 1, reason Error

I'll kick this again tonight after the CI load has dropped off.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 26, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 27, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 58d98c3 into openshift:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

@steveej steveej Awaiting requested review from steveej

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hardys @abhinavdahiya @openshift-ci-robot @openshift-merge-robot @wking