Skip to content

Alibaba: fix: use EXACT search mode #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 30, 2021
Merged

Alibaba: fix: use EXACT search mode #5411

openshift-merge-robot merged 1 commit into from
Nov 30, 2021

Conversation

@bd233
Copy link
Contributor

@bd233 bd233 commented Nov 23, 2021

The LIKE is default search mode on DescribeDomains api, In this mode,
if you search openshift.com, can match xx.openshift.com and
openshift.com.xx, but using EXACT mode, only return openshift.com.

@bd233
Alibaba: fix: use EXACT search mode
712c88c 
The LIKE is default search mode on DescribeDomains api, In this mode,
if you search openshift.com, can match xx.openshift.com and
openshift.com.xx, but using EXACT mode, only return openshift.com.

Signed-off-by: sunhui <[email protected]>
@openshift-ci openshift-ci bot requested review from jstuever and rna-afk November 23, 2021 14:30
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

Hi @bd233. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bd233
Copy link
Contributor Author

bd233 commented Nov 23, 2021

@kwoodson @patrickdillon This solves the same problem as this

staebler
staebler reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I cannot test this.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@kwoodson
Copy link

kwoodson commented Nov 25, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2021
@kwoodson kwoodson mentioned this pull request Nov 30, 2021
Merged
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@kwoodson kwoodson removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@kwoodson
Copy link

kwoodson commented Nov 30, 2021

@bd233 I tested this along with #5421. This did work as intended. Please address feedback in that PR. Thanks!

/lgtm

@kwoodson kwoodson added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@kwoodson
Copy link

kwoodson commented Nov 30, 2021

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kwoodson
Copy link

kwoodson commented Nov 30, 2021

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021 •
edited
Loading

@bd233: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws 712c88c link false /test okd-e2e-aws
ci/prow/e2e-ovirt 712c88c link false /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel7 712c88c link false /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws-upgrade 712c88c link false /test okd-e2e-aws-upgrade
ci/prow/e2e-crc 712c88c link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8cfe1ff into openshift:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@rna-afk rna-afk Awaiting requested review from rna-afk

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwoodson kwoodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bd233 @kwoodson @openshift-bot @staebler @openshift-merge-robot