Bug 2025901: Improve host role management during assets creation by andfasano · Pull Request #5409 · openshift/installer

andfasano · 2021-11-23T10:47:08Z

This patch ports back in 4.8 branch the fix implemented in PR #5205

The logic for generating baremetal manifests and Terraform variables now takes into account the host role tag properly, if defined. This allows to define master/worker hosts in any order. To remain backward compatible, if an host does not have any role defined (or supported value), it's considered eligible for the ControlPlane or Compute respectively, based on the configured requirements. The validation rule has been enhanced to verify that the correct number of hosts have been configured.

…s without a role will be used either for ControlPlane or Compute respectively if required.

openshift-ci · 2021-11-23T10:47:10Z

@andfasano: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Improve host role management during assets creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-23T10:49:40Z

@andfasano: This pull request references Bugzilla bug 2025901, which is invalid:

expected dependent Bugzilla bug 2003113 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2025901: Improve host role management during assets creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-11-23T10:49:49Z

/label platform/baremetal

andfasano · 2021-12-20T14:37:06Z

/bugzilla refresh

openshift-ci · 2021-12-20T14:37:10Z

@andfasano: This pull request references Bugzilla bug 2025901, which is invalid:

expected dependent Bugzilla bug 2003113 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T15:04:59Z

/bugzilla refresh

openshift-ci · 2021-12-20T15:05:02Z

@andfasano: This pull request references Bugzilla bug 2025901, which is invalid:

expected dependent Bugzilla bug 2003113 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T15:09:21Z

/bugzilla refresh

openshift-ci · 2021-12-20T15:09:24Z

@andfasano: This pull request references Bugzilla bug 2025901, which is invalid:

expected Bugzilla bug 2025901 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T16:55:58Z

/hold waiting to land BZ 2025862 first

openshift-bot · 2022-01-01T00:01:12Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2022-01-01T00:02:16Z

@openshift-bot: This pull request references Bugzilla bug 2025901, which is invalid:

expected the bug to target the "4.8.z" release, but it targets "---" instead
expected Bugzilla bug 2025901 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtantsur · 2022-01-07T09:37:50Z

/bugzilla refresh

openshift-ci · 2022-01-07T09:37:54Z

@dtantsur: This pull request references Bugzilla bug 2025901, which is invalid:

expected dependent Bugzilla bug 2025862 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elfosardo · 2022-04-22T06:10:31Z

/unhold
/retest

sadasu · 2022-06-01T02:46:00Z

/bugzilla refresh

openshift-ci · 2022-06-01T02:46:08Z

@sadasu: This pull request references Bugzilla bug 2025901, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2025862 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2025862 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
bug has dependents

Requesting review from QA contact:
/cc @omichaeli

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2022-06-01T02:46:45Z

/lgtm

omichaeli · 2022-06-02T13:44:43Z

/label cherry-pick-approved

sadasu · 2022-06-02T15:34:46Z

/approve

sadasu · 2022-07-25T13:44:12Z

/assign @wking

sadasu · 2022-07-27T13:03:32Z

/assign @patrickdillon

patrickdillon · 2022-08-16T18:36:48Z

/approve
/label backport-risk-assessed

openshift-ci · 2022-08-16T18:37:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-08-16T21:22:53Z

/retest-required

Remaining retests: 2 against base HEAD 25364a4 and 8 for PR HEAD 57cc890 in total

openshift-ci · 2022-08-16T23:15:54Z

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-08-16T23:30:30Z

@andfasano: All pull requests linked via external trackers have merged:

openshift/installer#5409

Bugzilla bug 2025901 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2025901: Improve host role management during assets creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano added 2 commits November 23, 2021 05:17

Reorder hosts to first select those ones with a configured role. Host…

57cc890

…s without a role will be used either for ControlPlane or Compute respectively if required.

openshift-ci Bot requested review from celebdor and dhellmann November 23, 2021 10:48

andfasano changed the title ~~Improve host role management during assets creation~~ Bug 2025901: Improve host role management during assets creation Nov 23, 2021

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 23, 2021

openshift-ci Bot added the platform/baremetal IPI bare metal hosts platform label Nov 23, 2021

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 1, 2022

openshift-ci Bot requested a review from omichaeli June 1, 2022 02:46

openshift-ci Bot assigned sadasu Jun 1, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 2, 2022

openshift-ci Bot assigned wking Jul 25, 2022

openshift-ci Bot assigned patrickdillon Jul 27, 2022

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 16, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022

openshift-merge-robot merged commit 6aebff5 into openshift:release-4.8 Aug 16, 2022

Conversation

andfasano commented Nov 23, 2021

Uh oh!

openshift-ci Bot commented Nov 23, 2021

Uh oh!

openshift-ci Bot commented Nov 23, 2021

Uh oh!

andfasano commented Nov 23, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-bot commented Jan 1, 2022

Uh oh!

openshift-ci Bot commented Jan 1, 2022

Uh oh!

dtantsur commented Jan 7, 2022

Uh oh!

openshift-ci Bot commented Jan 7, 2022

Uh oh!

elfosardo commented Apr 22, 2022

Uh oh!

sadasu commented Jun 1, 2022

Uh oh!

openshift-ci Bot commented Jun 1, 2022

Uh oh!

sadasu commented Jun 1, 2022

Uh oh!

omichaeli commented Jun 2, 2022

Uh oh!

sadasu commented Jun 2, 2022

Uh oh!

sadasu commented Jul 25, 2022

Uh oh!

sadasu commented Jul 27, 2022

Uh oh!

patrickdillon commented Aug 16, 2022

Uh oh!

openshift-ci Bot commented Aug 16, 2022

Uh oh!

openshift-ci-robot commented Aug 16, 2022

Uh oh!

openshift-ci Bot commented Aug 16, 2022

Uh oh!

openshift-ci Bot commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants