Bug 2025862: Improve host role management during assets creation by andfasano · Pull Request #5408 · openshift/installer

andfasano · 2021-11-23T08:56:37Z

This patch ports back in 4.9 branch the fix implemented in PR #5205

The logic for generating baremetal manifests and Terraform variables now takes into account the host role tag properly, if defined. This allows to define master/worker hosts in any order. To remain backward compatible, if an host does not have any role defined (or supported value), it's considered eligible for the ControlPlane or Compute respectively, based on the configured requirements. The validation rule has been enhanced to verify that the correct number of hosts have been configured.

…s without a role will be used either for ControlPlane or Compute respectively if required.

openshift-ci · 2021-11-23T08:56:38Z

@andfasano: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

BZ 2025862

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-23T08:59:28Z

@andfasano: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2025862

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-23T09:43:24Z

@andfasano: An error was encountered querying GitHub for users with public email (omichael@redhat.com) for bug 2025862 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2025862: Improve host role management during assets creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-11-23T09:52:32Z

/label platform/baremetal

sadasu · 2021-11-29T14:56:06Z

/retest

andfasano · 2021-12-20T14:32:21Z

/bugzilla refresh

openshift-ci · 2021-12-20T14:32:26Z

@andfasano: This pull request references Bugzilla bug 2025862, which is invalid:

expected dependent Bugzilla bug 2025901 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2025901 to target a release in 4.10.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T16:44:12Z

/bugzilla refresh

openshift-ci · 2021-12-20T16:44:17Z

@andfasano: This pull request references Bugzilla bug 2025862, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T16:45:16Z

/bugzilla refresh

openshift-ci · 2021-12-20T16:45:21Z

@andfasano: This pull request references Bugzilla bug 2025862, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2003113 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2003113 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @omichaeli

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

staebler · 2021-12-21T16:07:31Z

/approve

openshift-ci · 2021-12-21T16:08:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omichaeli, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sadasu · 2021-12-21T16:43:03Z

/lgtm

openshift-bot · 2022-05-03T21:53:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-03T22:43:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T00:43:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T01:31:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T04:19:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T05:31:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T08:56:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T10:32:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T15:10:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-04T17:46:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

sadasu · 2022-05-04T20:14:03Z

/skip
All changes are specific to baremetal so should not affect the aws-upgrade job

sadasu · 2022-05-04T20:17:25Z

/label backport-risk-assessed

omichaeli · 2022-05-08T05:51:45Z

/label cherry-pick-approved

openshift-ci · 2022-05-08T05:51:46Z

@omichaeli: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2022-05-23T21:33:08Z

/retest-required

openshift-bot · 2022-05-23T22:36:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T00:46:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T01:25:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T03:45:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T04:48:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T06:45:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T08:29:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T12:25:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-05-24T14:05:46Z

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-upgrade	`b89d14e`	link	false	`/test okd-e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-05-24T16:13:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-24T16:25:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-05-24T18:04:53Z

@andfasano: All pull requests linked via external trackers have merged:

openshift/installer#5408

Bugzilla bug 2025862 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2025862: Improve host role management during assets creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano added 2 commits November 19, 2021 03:57

Reorder hosts to first select those ones with a configured role. Host…

b89d14e

…s without a role will be used either for ControlPlane or Compute respectively if required.

openshift-ci Bot requested review from celebdor and dhellmann November 23, 2021 08:58

andfasano changed the title ~~BZ 2025862~~ Bug 2025862 Nov 23, 2021

andfasano changed the title ~~Bug 2025862~~ Bug 2025862: Improve host role management during assets creation Nov 23, 2021

openshift-ci Bot added the platform/baremetal IPI bare metal hosts platform label Nov 23, 2021

openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 20, 2021

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 20, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 20, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 20, 2021

openshift-ci Bot requested a review from omichaeli December 20, 2021 16:45

omichaeli approved these changes Dec 21, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021

openshift-ci Bot assigned sadasu Dec 21, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 4, 2022

dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 23, 2022

openshift-merge-robot merged commit 79ddfd2 into openshift:release-4.9 May 24, 2022

Conversation

andfasano commented Nov 23, 2021

Uh oh!

openshift-ci Bot commented Nov 23, 2021

Uh oh!

openshift-ci Bot commented Nov 23, 2021

Uh oh!

openshift-ci Bot commented Nov 23, 2021

Uh oh!

hardys commented Nov 23, 2021

Uh oh!

sadasu commented Nov 29, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-ci Bot commented Dec 20, 2021

Uh oh!

staebler commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

sadasu commented Dec 21, 2021

Uh oh!

openshift-bot commented May 3, 2022

Uh oh!

openshift-bot commented May 3, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

openshift-bot commented May 4, 2022

Uh oh!

sadasu commented May 4, 2022

Uh oh!

sadasu commented May 4, 2022

Uh oh!

omichaeli commented May 8, 2022

Uh oh!

openshift-ci Bot commented May 8, 2022

Uh oh!

sadasu commented May 23, 2022

Uh oh!

openshift-bot commented May 23, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-bot commented May 24, 2022

Uh oh!

openshift-ci Bot commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 24, 2022 •

edited

Loading