Skip to content

[release-4.8] Bug 2022171: Relax vcenter hostname check #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Dec 14, 2021
Merged

[release-4.8] Bug 2022171: Relax vcenter hostname check #5371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/validate/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,5 @@ func Host(v string) error {
if proxyIP != nil {
return nil
}
re := regexp.MustCompile("^[a-z]")
if !re.MatchString(v) {
return errors.New("domain name must begin with a lower-case letter")
}
return validateSubdomain(v)
}
3 changes: 1 addition & 2 deletions pkg/validate/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func TestVCenter(t *testing.T) {
{"single lowercase", "a", true},
{"single uppercase", "A", false},
{"contains whitespace", "abc D", false},
{"single number", "1", false},
{"single number", "1", true},
{"single dot", ".", false},
{"ends with dot", "a.", false},
{"starts with dot", ".a", false},
Expand All @@ -115,7 +115,6 @@ func TestVCenter(t *testing.T) {
{"contains non-ascii", "a日本語a", false},
{"URLs", "https://hello.openshift.org", false},
{"IP", "192.168.1.1", true},
{"invalid IP", "192.168.1", false},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
Expand Down