asset/store: clean up logging and logic #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging the asset names and paths in the asset store, escape the names and paths. This will make it a bit easier to read when there are spaces in the name.
There is no need to mislead developers. Just use the name of the package.
openshift-ci-robot
added
approved
Member
|
gofmt ;). |
Contributor
Author
|
@wking Hrmm. I'm using Go 1.11 on my system which apparently changed those formatting rules. |
Member
Bump release? Forward to the future! ;) |
This cleans up the log messages so they are a little more clear to the user. This also cleans up the logic related to determining the source of assets. The behavior is still the same as before, it's just a little easier to follow.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jan 10, 2019
Also alphabetize all the non-stdlib imports in a single block. The logrus import change is similar to our earlier 54ba6a7 (asset/ignition: don't rename imports, 2018-10-24, openshift#534).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the log messages so they are a little more clear to the
user. This also cleans up the logic related to determining the source of
assets. The behavior is still the same as before, it's just a little
easier to follow.