Skip to content

Use Openshift Cluster API instead of MachineAPIOperator#5331

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
kirankt:openshift-api-instead-of-mao
Nov 3, 2021
Merged

Use Openshift Cluster API instead of MachineAPIOperator#5331
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
kirankt:openshift-api-instead-of-mao

Conversation

@kirankt
Copy link
Contributor

@kirankt kirankt commented Oct 26, 2021

Reduce the references to MachineAPIOperator for Cluster API and instead we will utilize OpenShift API. The MachineAPIOperator must still be vendored for the time being because of the vsphere CAPI provider resides within its repo unlike other providers who have their own separate repo.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021
@openshift-ci openshift-ci bot requested review from adduarte and celebdor October 26, 2021 16:35
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for some optional tests to pass

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@staebler
Copy link
Contributor

/test e2e-aws
/test e2e-gcp

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@kirankt
Copy link
Contributor Author

kirankt commented Oct 27, 2021

/retest

@kirankt kirankt changed the title [WIP] Use Openshift Cluster API instead of MachineAPIOperator Use Openshift Cluster API instead of MachineAPIOperator Oct 27, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
@patrickdillon
Copy link
Contributor

/retest

All of the failing tests have successful installs, so I doubt any of the failures are related to this PR.

@kirankt
Copy link
Contributor Author

kirankt commented Oct 28, 2021

/retest

@patrickdillon
Copy link
Contributor

/test e2e-aws

I think this is the only test we should be waiting on. It looks like rhel workers is permafailing again and e2e-crc is not a reliable test.

@patrickdillon
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2021
@patrickdillon
Copy link
Contributor

/hold cancel

This looks good, but I suspect we might be able to do much more in this area. I will follow up on it and report back here or in slack.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2021
@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 2, 2021

It looks like we should also be able to remove the cluster-api provider dependencies for aws, gcp, and azure as well. Incremental progress is good, so let's merge this and close CORS-1788 but I think we should open a new card as well. I will leave a comment in CORS-1788

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

@kirankt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 e1ccf44 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 e1ccf44 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc e1ccf44 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants