Power VS GetSession persistant variables#5319
Power VS GetSession persistant variables#531923TNC wants to merge 2 commits intoopenshift:masterfrom 23TNC:powervs-session-changes
Conversation
|
Hi @23TNC. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
clnperez
left a comment
clnperez
left a comment
There was a problem hiding this comment.
some small comments and we can test this.
also it'll require a rebase after the other PRs are merged but we can figure that out. too many moving parts for the time being.
| 1) require the user has done this already and pull from the file | ||
| 2) ask the user to paste in their IAMToken. | ||
| 3) let the password env var be the IAMToken? (Going with this atm since it's how I started) | ||
| 4) put it into Platform {userid: , iamtoken: , ...} |
There was a problem hiding this comment.
can we delete this whole block? this is all pretty outdated brainstorming from months ago :D
and we should document that users may optionally do ibmcloud iam api-key-create test --file ~/.bluemix/apikey_test.json --output json to get that file there.
|
|
||
| // Second grab variables from files | ||
|
|
||
| // .bluemix/config.json doesn't seem to hold anything useful but other files might |
There was a problem hiding this comment.
did you run ibmcloud iam api-key-create test --file ~/.bluemix/apikey_test.json --output json ?
| // region can be found in this file, but may not be the region the user would like to use | ||
| // zone cannot be found in this file | ||
| // username cannot be found in this file | ||
| // apikey cannot be found in this file, iamtoken is not the apikey we need |
There was a problem hiding this comment.
also let's clean up these comments for the pr. nice to have to kick off these discussions to start
| { | ||
| Prompt: &survey.Password{ | ||
| Message: "IBM Cloud API Key", | ||
| Help: "The api key installation.\nhttps://cloud.ibm.com/iam/apikeys", |
There was a problem hiding this comment.
capitalize API in the help text
|
@cklokman can you close this? I'm closing my open outdated ones. |
3 participants
Depends on PR #5293
This changes GetSession to read variables from disk, and save variable to disk. This is important as we are able to save the variables to disk after create install-config and read them back in later in the process. This will prevent the user from being prompted two or more times for the same information.