Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jul 13, 2018

Catching up with e22e31f (coreos/tectonic-installer#3142). Running bazel build tarball on master actually gets you a tectonic-dev.tar.gz with a root tectonic-dev directory, but I've left that alone for now (maybe it depends on environment variables like cutting releases?). The tarball I built also lacks the darwin/linux subdirectories:

$ tree tectonic-dev/installer/
tectonic-dev/installer/
├── tectonic
└── terraform

But by stopping at the installer directory I don't have to worry about figuring out how cross-platform builds work now ;).

Fixes #33.

@openshift-ci-robot openshift-ci-robot added retest-not-required-docs-only needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2018
@wking wking force-pushed the doc-new-tarball-directories branch from 9b6417e to 1a554cf Compare July 16, 2018 04:05
Copy link
Contributor

@yifan-gu yifan-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@yifan-gu
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2018
Catching up with e22e31f (Simplified Bazel build, 2018-04-23,
coreos/tectonic-installer#3142).  Running 'bazel build tarball' on
master actually gets you a tectonic-dev.tar.gz with a root
tectonic-dev directory, but I've left that alone for now (maybe it
depends on environment variables like cutting releases?).  The tarball
I built also lacks the darwin/linux subdirectories:

  $ tree tectonic-dev/installer/
  tectonic-dev/installer/
  ├── tectonic
  └── terraform

But by stopping at the 'installer' directory I don't have to worry
about figuring out how cross-platform builds work now ;).
@wking wking force-pushed the doc-new-tarball-directories branch from 1a554cf to e187c18 Compare July 20, 2018 21:57
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@wking
Copy link
Member Author

wking commented Jul 20, 2018

Rebased to get a new hash for Prow to avoid:

* aws_iam_role.etcd_role: Error creating IAM Role ci-op-2n8ifypw-68485-etcd-role: EntityAlreadyExists: Role with name ci-op-2n8ifypw-68485-etcd-role already exists.
    status code: 409, request id: 5f180a1f-8c60-11e8-9bb4-133f5ea804b8

in the batch-merge job. Hopefully that unsticks the tide merge pool, but it means this PR needs a fresh LGTM. @yifan-gu?

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@wking
Copy link
Member Author

wking commented Jul 20, 2018

This time the e2e-aws errors were:

3 error(s) occurred:

* module.vpc.aws_route_table_association.worker_routing[5]: index 5 out of range for list aws_route_table.private_routes.*.id (max 5) in:

${aws_route_table.private_routes.*.id[count.index]}
* module.vpc.data.aws_route_table.worker[5]: data.aws_route_table.worker.5: Your query returned no results. Please change your search criteria and try again.
* module.vpc.aws_route.to_nat_gw[5]: index 5 out of range for list aws_route_table.private_routes.*.id (max 5) in:

${aws_route_table.private_routes.*.id[count.index]}

@yifan-gu
Copy link
Contributor

retest

@wking
Copy link
Member Author

wking commented Jul 24, 2018

retest

@yifan-gu, I think you meant /retest?

@yifan-gu
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Jul 24, 2018

This time the e2e-aws error was an interrupt signal:

2018/07/24 22:00:00 Container test in pod e2e-aws completed successfully
{"component":"entrypoint","level":"error","msg":"Entrypoint received interrupt: terminated","time":"2018-07-24T22:05:45Z"}
2018/07/24 22:05:45 error: Process interrupted with signal interrupt, exiting in 2s ...
2018/07/24 22:05:45 cleanup: Deleting template e2e-aws

@yifan-gu
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Jul 25, 2018

This time the e2e-aws error was:

* aws_launch_configuration.worker_conf: Error creating launch configuration: AlreadyExists: Launch Configuration by this name already exists - A launch configuration already exists with the name ci-op-nj8csswq-68485-worker-20180725185159419400000001
	status code: 400, request id: d44dd17f-903b-11e8-bad1-dd6846aecb37

/retest

@wking
Copy link
Member Author

wking commented Jul 25, 2018

This time the e2e-aws errors were:

3 error(s) occurred:

* module.vpc.aws_eip.nat_eip[0]: 1 error(s) occurred:

* aws_eip.nat_eip.0: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: 32c29992-2ad5-40e8-b0e5-524c22493368
* module.vpc.aws_eip.nat_eip[4]: 1 error(s) occurred:

* aws_eip.nat_eip.4: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: ab2739f6-d17f-4747-81e7-6643d31005d8
* module.vpc.aws_eip.nat_eip[1]: 1 error(s) occurred:

* aws_eip.nat_eip.1: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: d62268c1-6d36-4604-aaaf-eabd7b2e5fc7

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8d9fc11 into openshift:master Jul 25, 2018
@wking wking deleted the doc-new-tarball-directories branch July 25, 2018 22:42
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Apr 30, 2019
Add a Dockerfile for building an installer binary image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants