-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Documentation/dev/build: "tectonic-installer" -> "installer" #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation/dev/build: "tectonic-installer" -> "installer" #53
Conversation
9b6417e to
1a554cf
Compare
yifan-gu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
|
/ok-to-test |
Catching up with e22e31f (Simplified Bazel build, 2018-04-23, coreos/tectonic-installer#3142). Running 'bazel build tarball' on master actually gets you a tectonic-dev.tar.gz with a root tectonic-dev directory, but I've left that alone for now (maybe it depends on environment variables like cutting releases?). The tarball I built also lacks the darwin/linux subdirectories: $ tree tectonic-dev/installer/ tectonic-dev/installer/ ├── tectonic └── terraform But by stopping at the 'installer' directory I don't have to worry about figuring out how cross-platform builds work now ;).
1a554cf to
e187c18
Compare
|
New changes are detected. LGTM label has been removed. |
|
Rebased to get a new hash for Prow to avoid: in the batch-merge job. Hopefully that unsticks the tide merge pool, but it means this PR needs a fresh LGTM. @yifan-gu? |
|
This time the e2e-aws errors were: |
|
retest |
@yifan-gu, I think you meant |
|
/retest |
|
This time the e2e-aws error was an interrupt signal: |
|
/retest |
|
This time the e2e-aws error was: /retest |
|
This time the e2e-aws errors were: /retest |
Add a Dockerfile for building an installer binary image
Catching up with e22e31f (coreos/tectonic-installer#3142). Running
bazel build tarballon master actually gets you atectonic-dev.tar.gzwith a roottectonic-devdirectory, but I've left that alone for now (maybe it depends on environment variables like cutting releases?). The tarball I built also lacks thedarwin/linuxsubdirectories:But by stopping at the
installerdirectory I don't have to worry about figuring out how cross-platform builds work now ;).Fixes #33.