Skip to content

Conversation

@miabbott
Copy link
Member

…acts

It is possible to feed the update-rhcos-bootimage.py script a
meta.json input that does not contain all the boot image artifacts
required when doing a boot image bump. This changes the script to bail
out if the length of the images dict is less than or equal to 2,
which indicates that only the ostree tarball and qemu qcow2 image
were produced as part of an RHCOS build.

…acts

It is possible to feed the `update-rhcos-bootimage.py` script a
`meta.json` input that does not contain all the boot image artifacts
required when doing a boot image bump. This changes the script to bail
out if the `images` dict is missing well known artifacts that are
expected when doing an x86_64 boot image bump.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2021

@miabbott: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 b71781f link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 b71781f link false /test e2e-aws-workers-rhel8
ci/prow/e2e-libvirt b71781f link false /test e2e-libvirt
ci/prow/e2e-metal-ipi-ovn-ipv6 b71781f link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc b71781f link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miabbott
Copy link
Member Author

miabbott commented Oct 4, 2021

This change doesn't affect any of the CI jobs, so I think any failures can be safely ignored in the context of this change.

@cgwalters
Copy link
Member

Note #5252 obsoletes this.
(But, this PR is obviously safer to backport, so we could in theory merge this first and then rebase 5252 on it. Or we could merge 5252 and just open backport PRs with this change)

@staebler
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2021

@miabbott: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2021
@miabbott
Copy link
Member Author

With #5252 being merged, this change is no longer necessary. A similar check should be added to the plume cosa2stream function

@miabbott miabbott closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants