-
Notifications
You must be signed in to change notification settings - Fork 1.5k
update-rhcos-bootimage: check that RHCOS metadata has necessary artif… #5254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…acts It is possible to feed the `update-rhcos-bootimage.py` script a `meta.json` input that does not contain all the boot image artifacts required when doing a boot image bump. This changes the script to bail out if the `images` dict is missing well known artifacts that are expected when doing an x86_64 boot image bump.
e21af75 to
b71781f
Compare
|
@miabbott: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This change doesn't affect any of the CI jobs, so I think any failures can be safely ignored in the context of this change. |
|
Note #5252 obsoletes this. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@miabbott: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
With #5252 being merged, this change is no longer necessary. A similar check should be added to the |
…acts
It is possible to feed the
update-rhcos-bootimage.pyscript ameta.jsoninput that does not contain all the boot image artifactsrequired when doing a boot image bump. This changes the script to bail
out if the length of the
imagesdict is less than or equal to 2,which indicates that only the
ostreetarball andqemuqcow2 imagewere produced as part of an RHCOS build.