Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable #5250

openshift-cherrypick-robot · 2021-09-29T10:01:19Z

This is an automated cherry-pick of #5110

/assign hardys

In openshift#4052 we added interfaces to control the MAC addresses for the NICs in the bootstrap VM, so that in environments where DHCP pools are not allowed, a static reservation can be made. Unfortunately that doesn't work in ipv6 environments currently, because NetworkManager needs a specific configuration similar to that applied via the MCO[1] for cluster hosts to ensure the generated client-ID is derived from the MAC and predictable. [1] https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-onprem.conf.yaml

These control the MAC for the bootstrap VM NICs, not the bridges on the host where the VM is running.

openshift-ci · 2021-09-29T10:01:24Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 1972524 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 53: Bugzilla_api_key is not a valid parameter for the Bugzilla::Bug::create function.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.8] Bug 1972524: baremetal: Ensure ipv6 bootstrap VM client-id is predictable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-09-29T10:03:01Z

/retitle Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable

openshift-ci · 2021-09-29T10:03:06Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2008823, which is invalid:

expected the bug to target the "4.8.z" release, but it targets "---" instead
expected Bugzilla bug 2008823 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-09-29T10:06:55Z

/bugzilla refresh

openshift-ci · 2021-09-29T10:07:00Z

@hardys: This pull request references Bugzilla bug 2008823, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1972524 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1972524 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-09-29T10:07:57Z

/cc @stbenjam @kirankt

hardys · 2021-09-29T16:08:47Z

/label platform/baremetal

kirankt

/approve

kirankt · 2021-09-29T17:52:22Z

/lgtm

hardys · 2021-10-05T12:09:51Z

/assign @patrickdillon - could you take a look and approve please? (we've not backported the addition of @kirankt to the 4.8 baremetal-approvers yet)

staebler · 2021-10-05T13:14:21Z

/approve

openshift-ci · 2021-10-05T13:14:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirankt, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~data/data/bootstrap/baremetal/OWNERS~~ [staebler]
~~docs/user/metal/OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-10-05T13:22:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T15:10:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T15:34:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T16:46:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T17:10:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T18:59:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T20:11:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T20:23:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T22:11:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-05T22:48:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-06T01:04:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-06T01:24:51Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-libvirt	`b6830dc`	link	false	`/test e2e-libvirt`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-10-06T02:18:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-06T03:20:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-06T04:22:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-06T04:24:03Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#5250

Bugzilla bug 2008823 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Steven Hardy added 2 commits September 29, 2021 10:01

baremetal: clarify docs for MACAddress options

b6830dc

These control the MAC for the bootstrap VM NICs, not the bridges on the host where the VM is running.

openshift-ci bot assigned hardys Sep 29, 2021

openshift-cherrypick-robot mentioned this pull request Sep 29, 2021

Bug 1972524: baremetal: Ensure ipv6 bootstrap VM client-id is predictable #5110

Merged

openshift-ci bot requested review from dhellmann and russellb September 29, 2021 10:02

openshift-ci bot changed the title ~~[release-4.8] Bug 1972524: baremetal: Ensure ipv6 bootstrap VM client-id is predictable~~ Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable Sep 29, 2021

openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 29, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 29, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 29, 2021

openshift-ci bot requested review from kirankt and stbenjam September 29, 2021 10:07

openshift-ci bot added the platform/baremetal IPI bare metal hosts platform label Sep 29, 2021

kirankt approved these changes Sep 29, 2021

View reviewed changes

openshift-ci bot assigned kirankt Sep 29, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021

knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 5, 2021

openshift-merge-robot merged commit 0c5cd91 into openshift:release-4.8 Oct 6, 2021

Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable #5250

Bug 2008823: baremetal: Ensure ipv6 bootstrap VM client-id is predictable #5250

Uh oh!

Conversation

openshift-cherrypick-robot commented Sep 29, 2021

Uh oh!

openshift-ci bot commented Sep 29, 2021

Uh oh!

hardys commented Sep 29, 2021

Uh oh!

openshift-ci bot commented Sep 29, 2021

Uh oh!

hardys commented Sep 29, 2021

Uh oh!

openshift-ci bot commented Sep 29, 2021

Uh oh!

hardys commented Sep 29, 2021

Uh oh!

hardys commented Sep 29, 2021

Uh oh!

kirankt left a comment

Choose a reason for hiding this comment

Uh oh!

kirankt commented Sep 29, 2021

Uh oh!

hardys commented Oct 5, 2021

Uh oh!

staebler commented Oct 5, 2021

Uh oh!

openshift-ci bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 5, 2021

Uh oh!

openshift-bot commented Oct 6, 2021

Uh oh!

openshift-ci bot commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 6, 2021

Uh oh!

openshift-bot commented Oct 6, 2021

Uh oh!

openshift-bot commented Oct 6, 2021

Uh oh!

openshift-ci bot commented Oct 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci bot commented Oct 6, 2021 •

edited

Loading