Docs: update instructions to install libvirt and libvirt-devel packages #514
Conversation
kikisdeliveryservice
changed the title
|
/cc: @wking @rphillips @cgwalters |
docs/dev/libvirt-howto.md
Outdated
There was a problem hiding this comment.
Why not change this to read instead:
sudo yum install libvirt
? That should pull in all of the configs, storage etc.
There was a problem hiding this comment.
@cgwalters : happy to do that, thanks for the suggestion!
@wking @rphillips : what do you think?
There was a problem hiding this comment.
sudo yum install libvirt? That should pull in all of the configs, storage etc.
It's surprising to me that libvirt-daemon doesn't pull in this configuration :p. While we're updating this, we probably also need libvirt-devel, because the destroy logic needs to link the C library.
There was a problem hiding this comment.
@wking so :
sudo yum install libvirt libvirt-devel
openshift-ci-robot
added
the
size/XS
kikisdeliveryservice
force-pushed
the
add-libvirtdaemon-config-network
branch
from
0f1b73c to
609d1a5
Compare
kikisdeliveryservice
changed the title
|
/lgtm glad you got it working |
|
/assign @wking |
rajatchopra
left a comment
rajatchopra
left a comment
There was a problem hiding this comment.
/lgtm
Fair deal. I did the same thing for my setup.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rajatchopra, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
7 participants
libvirt-daemon-config-networkis not installed by default when only installinglibvirt-daemonand is necessary for setting up the libvirt bridge and default networking.For reference, the error I was seeing running through a by the book install on a fresh F28: