Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 20, 2018

Adds ClusterK8sIO from e2dc955 (#468) and Master from 586ad45 (#491). Removes KubeCoreOperator from c9b0e2f (#420).

Generated with:

$ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

$ dot -V
dot - graphviz version 2.30.1 (20170916.1124)

Adds ClusterK8sIO from e2dc955 (pkg/asset: add ClusterK8sIO,
machines.Worker assets, 2018-10-15, openshift#468) and Master from 586ad45
(pkg/asset: Add asset for Master machines, 2018-10-18, openshift#491).  Removes
KubeCoreOperator from c9b0e2f (manifests: stop using kube core
operator, 2018-10-08, openshift#420).

Generated with:

  $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

  $ dot -V
  dot - graphviz version 2.30.1 (20170916.1124)
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 20, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2018
@wking wking force-pushed the rebuild-asset-graph branch from 2e02bf8 to a59f0c6 Compare October 20, 2018 21:56
@crawford
Copy link
Contributor

/lgtm

@abhinavdahiya abhinavdahiya added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2018
@openshift-merge-robot openshift-merge-robot merged commit 0f628c5 into openshift:master Oct 22, 2018
@wking wking deleted the rebuild-asset-graph branch October 22, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants