Skip to content

Conversation

@hasueki
Copy link
Contributor

@hasueki hasueki commented Jul 8, 2021

This adds platform provisioning check support for IBM Cloud. The check will validate if there's already a conflicting Kube API DNS record present in the user-provided CIS instance.

Changes:

  • New validation function to check DNS records, ValidatePreExitingPublicDNS()
  • New client method for fetching DNS records, GetDNSRecordsByName()
  • Rename client method,GetZoneIDByName() --> GetDNSZoneIDByName()
  • Unit test for new validation function
  • Move validation test suite to ibmcloud package
  • Move custom type definitions, DNSZoneResponse{} and EncryptionKeyResponse{} to pkg/types/ibmcloud

@openshift-ci openshift-ci bot requested review from e-tienne and jstuever July 8, 2021 17:21
@hasueki hasueki force-pushed the ibm-provision-check branch from d258bcd to d335862 Compare July 13, 2021 19:31
@jstuever jstuever self-assigned this Jul 14, 2021
@jstuever
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

@hasueki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr d335862 link /test e2e-openstack-kuryr
ci/prow/e2e-crc d335862 link /test e2e-crc
ci/prow/e2e-libvirt d335862 link /test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7 d335862 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2cda85e into openshift:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants