Skip to content

CHANGELOG: Document changes since v0.2.0 #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 22, 2018
Merged

CHANGELOG: Document changes since v0.2.0 #504

openshift-merge-robot merged 1 commit into from
Oct 22, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Oct 20, 2018

I've also updated the v0.2.0 docs to soften the claims about staged installs, since v0.3.0 adds "loading assets from user-edited files" while v0.2.0 only had "remembers previously-generated assets".

CC @abhinavdahiya, @crawford

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2018
@wking wking force-pushed the version-0.3.0 branch 2 times, most recently from cc93236 to 7c09662 Compare October 20, 2018 04:51
@wking
Copy link
Member Author

wking commented Oct 20, 2018

images:

2018/10/20 04:54:24 Copied 0.88Mi of artifacts from release-latest to /logs/artifacts/release-latest
rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:247: starting container process caused "process_linux.go:110: decoding init error from pipe caused \"read parent: connection reset by peer\""

e2e-aws:

18/10/20 04:54:30 Ran for 2m47s
error: could not run steps: failed to wait for release pod to complete: could not wait for pod completion: pod release-latest was already deleted

/retest

@wking
Copy link
Member Author

wking commented Oct 22, 2018

Rebased onto master and updated to set the release date to Monday with 7c09662 -> 40fc60e.

1 similar comment
@wking
Copy link
Member Author

wking commented Oct 22, 2018

Rebased onto master and updated to set the release date to Monday with 7c09662 -> 40fc60e.

@wking
Copy link
Member Author

wking commented Oct 22, 2018

Hung cluster:

2018/10/22 04:21:57 Container setup in pod e2e-aws completed successfully
2018/10/22 06:21:03 Container teardown in pod e2e-aws completed successfully
2018/10/22 06:21:14 Copying artifacts from e2e-aws into /logs/artifacts/e2e-aws
Another process exited

/retest

@wking
Copy link
Member Author

wking commented Oct 22, 2018

I've pushed 40fc60e -> b09a86c documenting the new delete command and its subcommands and the deprecation of delete-cluster (all from #493). Those seem like important, user-facing changes ;).

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 22, 2018

/approve

crawford
crawford reviewed Oct 22, 2018
View reviewed changes
CHANGELOG.md Outdated
Copy link
Contributor

@crawford crawford Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug with this. The bootstrap reports completed long before it actually completes :(

Copy link
Member Author

@wking wking Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bootstrap reports completed long before it actually completes...

I've mentioned this with b09a86c -> efbf298.

@wking
CHANGELOG: Document changes since v0.2.0
efbf298 
Through 9a73030 (Merge pull request openshift#507 from
wking/drop-tectonic-version, 2018-10-20).

I've also updated the v0.2.0 docs to soften the claims about staged
installs, since v0.3.0 adds "loading assets from user-edited files"
while v0.2.0 only had "remembers previously-generated assets".
@crawford
Copy link
Contributor

crawford commented Oct 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7c820ab into openshift:master Oct 22, 2018
@wking wking deleted the version-0.3.0 branch October 23, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@crawford crawford crawford left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @abhinavdahiya @crawford @openshift-ci-robot @openshift-merge-robot