Ibm cluster creation #5023

BobbyRadford · 2021-06-23T13:49:58Z

This PR is a followup to the IBM Cloud Scaffolding PR: #4923

It includes additional implementation to support executing openshift-install create manifests|ignition-configs|cluster. A full terraform implementation is included for cluster creation and bootstrap destroy. All manifests code has at least been stubbed out to support the IBMCloud platform. The IBM cluster API provider has been pulled in to support Machine/MachineSet provisioning.

Future work will flesh out the remaining implementation.

Enhancement doc: openshift/enhancements#773

Many of the commits are iterative improvements over earlier ones in the PR. If it would be more helpful to squash things down to one commit (excluding mod/vendors) I can certainly do that. Apologies for all the vendor changes! 😬

openshift-ci · 2021-06-23T13:50:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

BobbyRadford · 2021-06-24T14:06:34Z

/assign @jstuever

Shim out the manifest generation code to support the IBMCloud platform. We will come back in subsequent commits to flesh out logic for all of the manifests.

Support the Cloud Credentials Operator by storing creds in the proper manifests.

This is a first pass at the cloud-provider-config manifest generation. As the requirements for this come into focus, I'm sure this will need to change. Co-authored-by: Hidematsu Sueki <[email protected]>

* wip: terraform wiring * ibmcloud: dependencies for terraform-provider-ibm * temp: Disable PlatformQuotaCheck * fix(terraform): Update to work with installer * feat(ibmcloud): Generate TF variables * chore(ibmcloud): Placeholder for bootstrap removal * chore: Remove ./_temp dependency * chore: Reword TODO comments Co-Authored-By: Bobby Radford <[email protected]> * Revert "temp: Disable PlatformQuotaCheck" This reverts commit 29899cd0ff2e334dcfa29846495ad161533924a8. * chore(ibmcloud): Add placeholder for quota checks * fix(ibmcloud): Create resource group if set to empty Co-authored-by: Bobby Radford <[email protected]>

This commit automates the custom image upload and creation for VPC VSIs. Inspiration was taken from the vsphere platform to implement this using Terraform. This commit eliminates the custom image prerequisite from IBM Cloud * fix: printer test * fix: terraform improvements Co-authored-by: Hidematsu Sueki <[email protected]>

Add IBMCloud Metadata to the InstallConfig asset. This is used to compute things like the CISInstanceCRN using other user provided data.

jstuever

Overall looks solid. A couple minor tweaks.

data/data/ibmcloud/bootstrap/main.tf

data/data/ibmcloud/bootstrap/templates/bootstrap.ign

pkg/asset/installconfig/ibmcloud/client.go

pkg/asset/machines/ibmcloud/machines.go

jstuever · 2021-07-02T16:15:12Z

/retest

BobbyRadford · 2021-07-02T18:00:19Z

@jstuever Thanks for the review. We'll be working on fixes to address your comments this afternoon.

BobbyRadford · 2021-07-06T13:06:16Z

@jstuever Anything left for us to touch up?

jstuever · 2021-07-06T16:00:45Z

/lgtm
/approve

openshift-ci · 2021-07-06T16:01:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-06T16:08:51Z

/retest