Bug 1956485: bump RHCOS 4.6 boot images #5011

miabbott · 2021-06-17T13:33:18Z

This boot image bump for RHCOS 4.6 fixes the following BZs:

1956491 - CVE-2021-3114 ignition: golang: crypto/elliptic: incorrect operations on the P-224 curve
1960750 - RHCOS PXE deployment script coreos-livepxe-rootfs randomly fails to download and verify the image with bonding LACP active-active

Additionally, this includes the AMI published to the ap-northeast-3
(Osaka) region.

46.82.202106161040-0 amd64
46.82.202106162140-0 ppc64le
46.82.202106161139-0 s390x

This boot image bump for RHCOS 4.6 fixes the following BZs: 1956491 - CVE-2021-3114 ignition: golang: crypto/elliptic: incorrect operations on the P-224 curve 1960750 - RHCOS PXE deployment script coreos-livepxe-rootfs randomly fails to download and verify the image with bonding LACP active-active Additionally, this includes the AMI published to the ap-northeast-3 (Osaka) region. 46.82.202106161040-0 amd64 46.82.202106162140-0 ppc64le 46.82.202106161139-0 s390x

openshift-ci · 2021-06-17T13:33:26Z

@miabbott: This pull request references Bugzilla bug 1956485, which is invalid:

expected dependent Bugzilla bug 1956480 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1956485: bump RHCOS 4.6 boot images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2021-06-17T13:54:16Z

/bugzilla refresh

openshift-ci · 2021-06-17T13:54:30Z

@miabbott: This pull request references Bugzilla bug 1956485, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1956483 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1956483 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2021-06-17T13:55:07Z

/assign @dustymabe

miabbott · 2021-06-17T18:50:46Z

/retest

miabbott · 2021-06-18T18:34:44Z

@staebler the verify-codegen job is failing because I have an entry for ap-northeast-3 in the JSON. Should we /hold this PR until the changes to support any AWS region are backported to 4.6?

dustymabe

/lgtm

I assume this was generated with a tool I'm not supposed to go through and check each ID/checksum.

dustymabe · 2021-06-21T16:06:14Z

data/data/rhcos-amd64.json

+            "sha256": "b055fa9617ce10c8a5091f248927e62bfb1f050449078d80ecbc85f27a4c9c53",
+            "size": 907035912,
+            "uncompressed-sha256": "fa58c5bc8f796d8ff900cc731a0e0fa4c568bc7088d4ceb70eaf42549cffa7ec",
            "uncompressed-size": 17179869696


kind of cool (interesting) this size stayed the exact same.

dustymabe · 2021-06-21T16:06:47Z

/assign @wking

miabbott · 2021-06-24T21:06:40Z

/retest

thegreyd · 2021-06-30T15:21:35Z

/retest

miabbott · 2021-07-12T14:16:10Z

@staebler the verify-codegen job is failing because I have an entry for ap-northeast-3 in the JSON. Should we /hold this PR until the changes to support any AWS region are backported to 4.6?

@staebler could you weigh in on this?

patrickdillon · 2021-07-13T14:22:10Z

@staebler the verify-codegen job is failing because I have an entry for ap-northeast-3 in the JSON. Should we /hold this PR until the changes to support any AWS region are backported to 4.6?

It looks like you are just missing some generated code. You can amend your commit with the code generated from go generate ./pkg/rhcos/ami.go and it should pass. You can test locally with ./hack/verify-codegen.sh

Add the Osaka region via: `go generate ./pkg/rhcos/ami.go`

miabbott · 2021-07-13T16:53:02Z

/restest

miabbott · 2021-07-14T12:42:58Z

/retest

patrickdillon · 2021-07-14T13:42:31Z

/approve

miabbott · 2021-07-15T13:21:42Z

@dustymabe need another /lgtm on this

dustymabe

/lgtm

miabbott · 2021-07-15T15:22:46Z

Trying to grab some likely folks from https://github.com/openshift/installer/blob/release-4.6/OWNERS_ALIASES#L4-L10 (which kind of seems out-of-date IMO)

/assign @sdodson
/assign @wking

sdodson · 2021-07-15T15:24:23Z

/approve

sdodson · 2021-07-15T15:24:31Z

/retest-required

openshift-ci · 2021-07-15T15:24:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, patrickdillon, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-07-15T16:50:01Z

@miabbott: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	`51eb47c`	link	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sdodson · 2021-07-15T17:57:47Z

/override ci/prow/e2e-vsphere-upi
The installation completed.

openshift-ci · 2021-07-15T17:57:51Z

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-vsphere-upi

Details

In response to this:

/override ci/prow/e2e-vsphere-upi
The installation completed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2021-07-15T17:59:01Z

e2e-vsphere-upi has been majority red over the last 60 runs of the job. This PR hasn't affected that test.

One thing that jumps out immediately is that we are hitting the Docker rate limit all over the place:

error: tag latest failed: Internal error occurred: docker.io/library/busybox:latest: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

I found some references to how this has been changed for some tests but not all for 4.6 - https://bugzilla.redhat.com/show_bug.cgi?id=1963999#c5 -> openshift/origin#25721 (comment)

e2e-aws-workers-rhel7 has also been majority red/yellow over the last 60 runs of the job.

I found a BZ for the failure it is hitting which claims it was fixed - https://bugzilla.redhat.com/show_bug.cgi?id=1940392

...but seems like it is another style of failure here?

Filed a new BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1982795

sdodson · 2021-07-15T18:01:31Z

There's a PR out there to fix the docker hub pull limits. I'll see if I can push that forward.

sdodson · 2021-07-15T18:34:25Z

openshift/origin#26256 is the effort to switch from docker hub but it's massive and having a difficult time finding someone willing to review.

openshift-ci · 2021-07-15T20:05:13Z

@miabbott: All pull requests linked via external trackers have merged:

openshift/installer#5011

Bugzilla bug 1956485 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1956485: bump RHCOS 4.6 boot images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 17, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 17, 2021

openshift-ci bot requested review from jstuever and mtnbikenc June 17, 2021 13:33

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 17, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 17, 2021

openshift-ci bot requested a review from mike-nguyen June 17, 2021 13:54

openshift-ci bot assigned dustymabe Jun 17, 2021

dustymabe approved these changes Jun 21, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021

dustymabe reviewed Jun 21, 2021

View reviewed changes

openshift-ci bot assigned wking Jun 21, 2021

aws: add ap-northeast-3 region support

51eb47c

Add the Osaka region via: `go generate ./pkg/rhcos/ami.go`

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021

dustymabe approved these changes Jul 15, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021

openshift-ci bot assigned sdodson Jul 15, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 15, 2021

openshift-merge-robot merged commit 0f2496f into openshift:release-4.6 Jul 15, 2021

sdodson mentioned this pull request Jul 30, 2021

rhcos[-amd64].json: Manual add of ap-northeast-3 #4796

Closed

Bug 1956485: bump RHCOS 4.6 boot images #5011

Bug 1956485: bump RHCOS 4.6 boot images #5011

Uh oh!

Conversation

miabbott commented Jun 17, 2021

Uh oh!

openshift-ci bot commented Jun 17, 2021

Uh oh!

miabbott commented Jun 17, 2021

Uh oh!

openshift-ci bot commented Jun 17, 2021

Uh oh!

miabbott commented Jun 17, 2021

Uh oh!

miabbott commented Jun 17, 2021

Uh oh!

miabbott commented Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dustymabe left a comment

Choose a reason for hiding this comment

Uh oh!

dustymabe Jun 21, 2021

Choose a reason for hiding this comment

Uh oh!

dustymabe commented Jun 21, 2021

Uh oh!

miabbott commented Jun 24, 2021

Uh oh!

thegreyd commented Jun 30, 2021

Uh oh!

miabbott commented Jul 12, 2021

Uh oh!

patrickdillon commented Jul 13, 2021

Uh oh!

miabbott commented Jul 13, 2021

Uh oh!

miabbott commented Jul 14, 2021

Uh oh!

patrickdillon commented Jul 14, 2021

Uh oh!

miabbott commented Jul 15, 2021

Uh oh!

dustymabe left a comment

Choose a reason for hiding this comment

Uh oh!

miabbott commented Jul 15, 2021

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

openshift-ci bot commented Jul 15, 2021

Uh oh!

openshift-ci bot commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

openshift-ci bot commented Jul 15, 2021

Uh oh!

miabbott commented Jul 15, 2021

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

openshift-ci bot commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

miabbott commented Jun 18, 2021 •

edited

Loading

openshift-ci bot commented Jul 15, 2021 •

edited

Loading