Documentation/design: add prepare design #50
Merged
+93
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Contributor
Author
|
/retest |
abhinavdahiya
force-pushed
the
design_prepare
branch
from
7939df0 to
da7a532
Compare
yifan-gu
reviewed
Jul 12, 2018
Documentation/design/preparephase.md
Outdated
Contributor
There was a problem hiding this comment.
nit: maybe also add Example prepare output? Also indicate where users can put their customized files?
abhinavdahiya
force-pushed
the
design_prepare
branch
from
da7a532 to
bf830cc
Compare
Contributor
Author
|
/test e2e-aws |
1 similar comment
Contributor
Author
|
/test e2e-aws |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 23, 2018
The ".ign" suffix is sufficient to identify these as ignition filenames. The old filenames were from 461ff5f (cli: add support for user ignition files, 2018-03-23, coreos/tectonic-installer#3120), which does not motivate the "ingition-" prefix. This gets us closer to the filenames discussed in bf830cc (Documentation/design: add prepare design, 2018-07-11, openshift#50) and b111829 (Documentation/design: add launch design, 2018-07-11, openshift#51).
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Apr 30, 2019
Lower SRV record limit to 2
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
CVO-CBO integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add design doc for prepare step.