Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR #4987

yboaron · 2021-06-10T14:54:41Z

This PR addressed issue similar to [1] for the None platform,
since API VIP isn't used for None platform, the UseIPv6ForNodeIP
parameter should be calculated based on the content of service CIDR.

[1] #4756

openshift-ci · 2021-06-10T14:55:07Z

@yboaron: This pull request references Bugzilla bug 1957700, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (nshidlin@redhat.com), skipping review request.

Details

In response to this:

[WIP] Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2021-06-10T14:55:46Z

cc @celebdor

cybertron

This doesn't match the behavior of the masters in UPI: https://github.com/openshift/machine-config-operator/blob/847e2216cc324cfc17904e6afa6a18a47c565674/pkg/operator/render.go#L156 and https://github.com/openshift/machine-config-operator/blob/ecb3c0e03652049b5c37d9f5d5678e9d6dc24301/templates/common/_base/units/nodeip-configuration.service.yaml#L25

The difference is that on the nodes it only forces ipv6 for single-stack deployments. For dual-stack it will still use ipv4 (which should be fine since both are available). I'm not sure whether it matters since in dual-stack either should work, but I think it would be safer to be consistent.

Also, need to fix the fmt failure.

staebler · 2021-06-10T16:51:36Z

The difference is that on the nodes it only forces ipv6 for single-stack deployments. For dual-stack it will still use ipv4 (which should be fine since both are available). I'm not sure whether it matters since in dual-stack either should work, but I think it would be safer to be consistent.

Let's stay consistent with what is done in nodeip-configuration and only force ipv6 in single-stack.

staebler · 2021-06-10T16:53:05Z

Can you help me understand why we care about the service network for this? The errors in the bug are with connecting to the API server. The service network is not relevant to that. Why wouldn't we be looking at the machine network instead?

openshift-bot · 2021-06-14T08:26:49Z

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

openshift-ci · 2021-06-14T08:26:52Z

@openshift-bot: This pull request references Bugzilla bug 1957700, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-14T08:28:26Z

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

openshift-ci · 2021-06-14T08:28:29Z

@openshift-bot: This pull request references Bugzilla bug 1957700, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

e2e-metal-assisted-none-ipv6 jobs are failing for a long time. In order to reduce spamming on the CI channel, the alert would be removed until the job would return to work. The job should pass once openshift/installer#4987 is merged.

cybertron · 2021-06-25T15:04:44Z

/test e2e-vsphere-upi

I'm not entirely sure why we're using the service network for this, but it's what was used in MCO for determining whether kubelet should use ipv6.

jhixson74 · 2021-07-08T01:20:33Z

/uncc

This PR addressed issue similar to [1] for the None platform, since API VIP isn't used for None platform, the UseIPv6ForNodeIP parameter should be calculated based on the content of service CIDR. [1] openshift#4756

openshift-ci · 2021-07-18T14:21:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign patrickdillon after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickdillon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yboaron · 2021-07-18T14:30:21Z

/bugzilla refresh

openshift-ci · 2021-07-18T14:30:26Z

@yboaron: This pull request references Bugzilla bug 1957700, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (nshidlin@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2021-07-19T06:01:28Z

/retest

openshift-merge-robot · 2021-09-06T07:26:52Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2021-09-06T07:31:00Z

@openshift-merge-robot: This pull request references Bugzilla bug 1957700, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-29T00:46:22Z

@yboaron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-libvirt	`809eb3c`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-workers-rhel7	`809eb3c`	link	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-openstack-kuryr	`809eb3c`	link	`/test e2e-openstack-kuryr`
ci/prow/e2e-crc	`809eb3c`	link	`/test e2e-crc`
ci/prow/e2e-aws-workers-rhel8	`809eb3c`	link	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-alibaba	`809eb3c`	link	true	`/test e2e-alibaba`
ci/prow/e2e-gcp-upgrade	`809eb3c`	link	true	`/test e2e-gcp-upgrade`
ci/prow/e2e-aws-upgrade	`809eb3c`	link	true	`/test e2e-aws-upgrade`
ci/prow/e2e-azure-upi	`809eb3c`	link	true	`/test e2e-azure-upi`
ci/prow/e2e-aws-upi	`809eb3c`	link	true	`/test e2e-aws-upi`
ci/prow/e2e-gcp-upi	`809eb3c`	link	true	`/test e2e-gcp-upi`
ci/prow/e2e-vsphere	`809eb3c`	link	true	`/test e2e-vsphere`
ci/prow/e2e-gcp	`809eb3c`	link	true	`/test e2e-gcp`
ci/prow/e2e-azure	`809eb3c`	link	true	`/test e2e-azure`
ci/prow/e2e-aws	`809eb3c`	link	true	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sadasu · 2022-07-25T16:56:47Z

/close
Feel free to re-open it when needed.

openshift-merge-robot · 2022-07-25T16:56:55Z

@yboaron: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-25T16:58:34Z

@sadasu: Closed this PR.

Details

In response to this:

/close
Feel free to re-open it when needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-25T16:58:42Z

@yboaron: This pull request references Bugzilla bug 1957700. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
Warning: Failed to comment on Bugzilla bug with reason for changed state.

Details

In response to this:

Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021

openshift-ci bot requested review from jhixson74 and mtnbikenc June 10, 2021 14:54

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 10, 2021

yboaron changed the title ~~[WIP] Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR~~ Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR Jun 10, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021

cybertron suggested changes Jun 10, 2021

View reviewed changes

yboaron force-pushed the none_handler_v6 branch from 9b636b1 to 1c6fc65 Compare June 13, 2021 07:49

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 14, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 14, 2021

yboaron requested a review from cybertron June 17, 2021 09:08

YuviGold mentioned this pull request Jun 17, 2021

MGMT-6981 Remove assisted-none-ipv6 periodic job reporter openshift/release#19370

Merged

openshift-ci bot removed the request for review from jhixson74 July 8, 2021 01:20

None Platform: set Kubelet's node-ip param based on service net CIDR

809eb3c

This PR addressed issue similar to [1] for the None platform, since API VIP isn't used for None platform, the UseIPv6ForNodeIP parameter should be calculated based on the content of service CIDR. [1] openshift#4756

yboaron force-pushed the none_handler_v6 branch from 1c6fc65 to 809eb3c Compare July 18, 2021 14:20

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 18, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 18, 2021

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 6, 2021

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2022

openshift-ci bot closed this Jul 25, 2022

Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR #4987

Bug 1957700: None Platform - set Kubelet's node-ip param based on service net CIDR #4987

Uh oh!

Conversation

yboaron commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

yboaron commented Jun 10, 2021

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

staebler commented Jun 10, 2021

Uh oh!

staebler commented Jun 10, 2021

Uh oh!

openshift-bot commented Jun 14, 2021

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

openshift-bot commented Jun 14, 2021

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

cybertron commented Jun 25, 2021

Uh oh!

jhixson74 commented Jul 8, 2021

Uh oh!

openshift-ci bot commented Jul 18, 2021

Uh oh!

yboaron commented Jul 18, 2021

Uh oh!

openshift-ci bot commented Jul 18, 2021

Uh oh!

yboaron commented Jul 19, 2021

Uh oh!

openshift-merge-robot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Jun 29, 2022

Uh oh!

sadasu commented Jul 25, 2022

Uh oh!

openshift-merge-robot commented Jul 25, 2022

Uh oh!

openshift-ci bot commented Jul 25, 2022

Uh oh!

openshift-ci bot commented Jul 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants