Revert "pkg/asset: Introduce Load() into the Asset interface that loads assets (from disk)"

[deads2k]

Reverts #374

sorry @stevekuznetsov I don't know how to create this pull locally.

Multiple reports of: I run with libvirt and after this pull merged I see

[deads@deads-02 installer]$ bin/openshift-install cluster
FATAL Error executing openshift-install: open tests/smoke/vendor/github.com/prometheus/procfs/fixtures/26231/fd/0: no such file or directory

resetting to bf0fa6d gives me a working binary

@sallyom @djzager @yifan-gu @wking @abhinavdahiya

This is one option. If we know how to push through, I'm fine with that too.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

The error is because #374 allowed installer to read intermediate assets from the --dir. It looks like your --dir is set to root of repo, so it tries to read the files from tests dir... The deafult is .
@deads2k can you try --dir my-cluster when running the installer?

[wking]

Can we adjust to only load files that match paths from the graph?

[abhinavdahiya]

Yifans PR preloads the dir on startup and then serves the asset from internal cache.

[wking]

Would it be hard to populate on demand?

[crawford]

@wking is working on an alternate fix.

/hold

[wking]

Ok, I've pushed #497 replacing the early Walk loading with on-demand loading. I'm still testing locally, but it's up for other folks to start looking over.

[rajatchopra]

.

Ok, I've pushed #497 replacing the early Walk loading with on-demand loading. I'm still testing locally, but it's up for other folks to start looking over.

On-demand is clean, but it will be much slower. Can't we make Walk more robust? No need to error.. just put only valid values in the cache.

[wking]

On-demand is clean, but it will be much slower. Can't we make Walk more robust? No need to error.. just put only valid values in the cache.

How many files are we loading? Should be a handful of explicit files and a few globs. I can benchmark if you like, but I'm guessing this will be performant enough.

[stevekuznetsov]

@deads2k your git fu is bad and you should feel bad :)