Bug 1958420: aws: restore setting aws platform spec in infra resource #4916
Conversation
The code that set an empty `AWSPlatformSpec` in the infrastructure resource was accidentally removed when adding support for propagating user tags [1]. This causes the installer to panic when the install config included service endpoints. [1] openshift@2033421 https://bugzilla.redhat.com/show_bug.cgi?id=1958420
staebler
changed the title
openshift-ci
bot
added
the
bugzilla/severity-unspecified
|
@staebler: This pull request references Bugzilla bug 1958420, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
added
bugzilla/severity-urgent
|
@wking: This pull request references Bugzilla bug 1958420, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
rhbz#1950113 and #4755 made it into 4.7.10, so try and hustle this back to get it into 4.7.11. /cherrypick release-4.7 |
|
@wking: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
One update job passed and another failed on install. PR change is simple enough that the one pass makes me happy. /override e2e-aws-upgrade |
|
@wking: /override requires a failed status context to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-upgrade |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@staebler: All pull requests linked via external trackers have merged: Bugzilla bug 1958420 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: new pull request created: #4918 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
The code that set an empty
AWSPlatformSpecin the infrastructure resource was accidentally removed when adding support for propagating user tags. This causes the installer to panic when the install config included service endpoints.