Bump survey to v2

[ecordell]

I bumped survey to v2 in anticipation of pulling in a release that includes AlecAivazis/survey#353

If/when that merges, I can bump survey again to fix the input overwrite issue. This PR takes care of all of the other v1-> v2 changes ahead of time.

Example output with the patch:

Related to #4523

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wking after the PR has been reviewed.
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[staebler]

There is already a PR for this. #4895

[ecordell]

@staebler I didn't see that PR before I started on this one, but it looks like it's missing some important changes like this one:

https://github.com/openshift/installer/pull/4915/files#diff-4cf08c3b0708891421fe0a8f2eeee291bc6898cb545b5be1509bd31df62a9394R68

The types for all Select questions have changed, so all of the .(string) type assertions in the other PR will panic.

[ecordell]

I just saw this bug as well: https://bugzilla.redhat.com/show_bug.cgi?id=1947067

I originally bumped to v2 to see if that issue was fixed, because I've been running the installer a lot lately and it was bothering me. But just the bump to v2 did not fix it (on mac with iterm2), so I also opened AlecAivazis/survey#353 to address it.

[ecordell]

/retest

[ecordell]

/retest

[ecordell]

/retest

[mtnbikenc]

@staebler I didn't see that PR before I started on this one, but it looks like it's missing some important changes like this one:

https://github.com/openshift/installer/pull/4915/files#diff-4cf08c3b0708891421fe0a8f2eeee291bc6898cb545b5be1509bd31df62a9394R68

The types for all Select questions have changed, so all of the .(string) type assertions in the other PR will panic.

I've updated #4895 with these changes.

[openshift-ci]

@ecordell: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	b46fb10	link	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc	b46fb10	link	/test e2e-crc
ci/prow/e2e-aws-upgrade	b46fb10	link	/test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.