Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 18, 2018

@crawford gave the history behind our previous bucket name:

We should probably just fix the creation of the S3 bucket since we no longer rely on CNAMEs (which required the S3 bucket to match the domain name).

But now we can just let AWS pick a random bucket name for us.

I've also dropped the no-longer-used S3Bucket validator.

@crawford
Copy link
Contributor

/lgtm

@abhinavdahiya
Copy link
Contributor

This is PR is fine but the error

DEBUG error getting tags for bucket %!s(*string=0xc4207d0268): BucketRegionError: incorrect region, the bucket is not in 'us-east-2' region
     status code: 301, request id: , host id: , skipping...

Has nothing to do with the collision. openshift/hive@32cde50

Alex gave the history behind our previous bucket name [1]:

  We should probably just fix the creation of the S3 bucket since we
  no longer rely on CNAMEs (which required the S3 bucket to match the
  domain name).

But now we can just let AWS pick a random bucket name for us.

I've also dropped the no-longer-used S3Bucket validator.

[1]: openshift#359 (comment)
@wking wking force-pushed the drop-s3-bucket-name branch from 4ace06a to 05cd774 Compare October 18, 2018 19:59
@wking
Copy link
Member Author

wking commented Oct 18, 2018

This is PR is fine but the error...Has nothing to do with the collision. openshift/hive@32cde50

Thanks for pointing this out to me (a few times, and I finally understand it ;). I've pushed a new commit dropping the comment, which will blow away the lgtm. I'm excited to get kubernetes/test-infra#9138 over here so commit message changes can keep the labels :).

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@abhinavdahiya abhinavdahiya reopened this Oct 19, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2018
@abhinavdahiya
Copy link
Contributor

/test all

@openshift-merge-robot openshift-merge-robot merged commit 538ad20 into openshift:master Oct 19, 2018
@wking wking deleted the drop-s3-bucket-name branch October 19, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants