-
Notifications
You must be signed in to change notification settings - Fork 1.5k
data/aws: Drop the bucket name #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/aws: Drop the bucket name #489
Conversation
|
/lgtm |
|
This is PR is fine but the error Has nothing to do with the collision. openshift/hive@32cde50 |
Alex gave the history behind our previous bucket name [1]: We should probably just fix the creation of the S3 bucket since we no longer rely on CNAMEs (which required the S3 bucket to match the domain name). But now we can just let AWS pick a random bucket name for us. I've also dropped the no-longer-used S3Bucket validator. [1]: openshift#359 (comment)
4ace06a to
05cd774
Compare
Thanks for pointing this out to me (a few times, and I finally understand it ;). I've pushed a new commit dropping the comment, which will blow away the |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
@crawford gave the history behind our previous bucket name:
But now we can just let AWS pick a random bucket name for us.
I've also dropped the no-longer-used
S3Bucketvalidator.