Revert "Check if VIP IPs overlap with machine CIDR provided during vsphere installation"

[staebler]

Reverts #4754

When using the survey flow, the machine CIDR is not populated. This causes the installation to fail, unless the VIPs happen to be within the default machine CIDR.

[openshift-ci-robot]

@staebler: This pull request references Bugzilla bug 1918469, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

Revert "Bug 1918469: Check if VIP IPs overlap with machine CIDR provided during vsphere installation"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[staebler]

#4754 was also causing issues for https://github.com/openshift/release/blob/2b486afdfb79bb8361e93058d37acdd234501baf/ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml#L66-L71, where the workflow used does not set the machine CIDR.

[staebler]

/bugzilla ?

[openshift-ci-robot]

@staebler: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert "Check if VIP IPs overlap with machine CIDR provided during vsphere installation"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[staebler]

/test e2e-vsphere
/test e2e-vsphere-upi

[staebler]

/override ci/prow/e2e-aws-upgrade

[openshift-ci-robot]

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[staebler]

/approve

[staebler]

/hold for vsphere tests

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rna-afk]

/lgtm

[staebler]

/retest

[aravindhp]

@staebler I am seeing in some of the tests (e2e-vsphere):

 Downloading https://files.pythonhosted.org/packages/53/7f/55721ad0501a9076dbc354cc8c63ffc2d6f1ef360f49ad0fbcce19d68538/pip-20.3.4.tar.gz#sha256=6773934e5f5fc3eaa8c5a44949b5b924fc122daa0a8aa9f80c835b4ca2a543fc
error: https://files.pythonhosted.org/packages/53/7f/55721ad0501a9076dbc354cc8c63ffc2d6f1ef360f49ad0fbcce19d68538/pip-20.3.4.tar.gz#sha256=6773934e5f5fc3eaa8c5a44949b5b924fc122daa0a8aa9f80c835b4ca2a543fc hostname 'files.pythonhosted.org' doesn't match either of 'r.ssl.fastly.net', '*.catchpoint.com', '*.cnn.io', '*.dollarshaveclub.com', '*.eater.com', '*.fastly.picmonkey.com', '*.files.saymedia-content.com', '*.ft.com', '*.meetupstatic.com', '*.nfl.com', '*.pagar.me', '*.picmonkey.com', '*.realself.com', '*.sbnation.com', '*.shakr.com', '*.streamable.com', '*.surfly.com', '*.theverge.com', '*.thrillist.com', '*.vox-cdn.com', '*.vox.com', '*.voxmedia.com', 'eater.com', 'ft.com', 'i.gse.io', 'picmonkey.com', 'realself.com', 'static.wixstatic.com', 'streamable.com', 'surfly.com', 'theverge.com', 'vox-cdn.com', 'vox.com', 'www.joyent.com'
error: build error: error building at STEP "RUN easy_install 'pip<21'": error while running runtime: exit status 1 

Will the tests pass without fixing this?

[staebler]

@staebler I am seeing in some of the tests (e2e-vsphere):

 Downloading https://files.pythonhosted.org/packages/53/7f/55721ad0501a9076dbc354cc8c63ffc2d6f1ef360f49ad0fbcce19d68538/pip-20.3.4.tar.gz#sha256=6773934e5f5fc3eaa8c5a44949b5b924fc122daa0a8aa9f80c835b4ca2a543fc
error: https://files.pythonhosted.org/packages/53/7f/55721ad0501a9076dbc354cc8c63ffc2d6f1ef360f49ad0fbcce19d68538/pip-20.3.4.tar.gz#sha256=6773934e5f5fc3eaa8c5a44949b5b924fc122daa0a8aa9f80c835b4ca2a543fc hostname 'files.pythonhosted.org' doesn't match either of 'r.ssl.fastly.net', '*.catchpoint.com', '*.cnn.io', '*.dollarshaveclub.com', '*.eater.com', '*.fastly.picmonkey.com', '*.files.saymedia-content.com', '*.ft.com', '*.meetupstatic.com', '*.nfl.com', '*.pagar.me', '*.picmonkey.com', '*.realself.com', '*.sbnation.com', '*.shakr.com', '*.streamable.com', '*.surfly.com', '*.theverge.com', '*.thrillist.com', '*.vox-cdn.com', '*.vox.com', '*.voxmedia.com', 'eater.com', 'ft.com', 'i.gse.io', 'picmonkey.com', 'realself.com', 'static.wixstatic.com', 'streamable.com', 'surfly.com', 'theverge.com', 'vox-cdn.com', 'vox.com', 'www.joyent.com'
error: build error: error building at STEP "RUN easy_install 'pip<21'": error while running runtime: exit status 1 

Will the tests pass without fixing this?

So far, I do not have any reason to believe that the error is not transient. Some of the jobs were able to build the upi-installer image (eg, images, e2e-metal-single-node-live-iso).

/retest

[stbenjam]

Any reason to just not allow the survey to ask for machine network? I realize the survey should be minimal, but this one additional question would be useful. We run into this problem on the baremetal validations (cc: @kirankt)

[staebler]

Any reason to just not allow the survey to ask for machine network? I realize the survey should be minimal, but this one additional question would be useful. We run into this problem on the baremetal validations (cc: @kirankt)

@stbenjam We may fall back to that. In the case of vSphere, however, the user has been able to create and use clusters without issue for a long time now without having the machine CIDR match up with the actual machine network. There does not appear to be anything in the cluster that cares. And the installer does not care, since the installer is not directing instances into particular networks like it does for say AWS. We are looking into whether we can get the machine CIDR from the vSphere network at install time to fill out the machine CIDR in the install config on behalf of the user.

[aravindhp]

/retest

[aravindhp]

/retest

[openshift-ci]

@staebler: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	e67ea7d	link	/test e2e-crc
ci/prow/e2e-metal-ipi-ovn-ipv6	e67ea7d	link	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack	e67ea7d	link	/test e2e-openstack
ci/prow/e2e-aws-fips	e67ea7d	link	/test e2e-aws-fips
ci/prow/e2e-aws-workers-rhel7	e67ea7d	link	/test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[staebler]

Both vsphere jobs passed.
/hold cancel

[staebler]

/override ci/prow/e2e-aws-upgrade
/skip

[openshift-ci-robot]

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.