machines/openstack: re-enable external clientOpts#4638
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 11, 2021
Merged
Conversation
In 05453ef the MachineSets function was updated to remove the option to specify external clientOpts. This clientOpts is used by hive to generate the machinesets and ensuring the correct client authentication is used. using the default client opts as forced in 05453ef only allows configuring the openstack client using the default location on the host, which doesn't sit well with something like hive which needs to manage the machinesets for many different clients from single location. Reverting the change in 05453ef to allow machinesets to accept external clientOpts and use the default opts when it is nil.
Contributor
|
Openstack CI may be broken atm... |
Contributor
Author
|
/approve |
|
/label platform/openstack |
|
/hold for CI |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
abhinavdahiya
added a commit
to abhinavdahiya/hive
that referenced
this pull request
Feb 9, 2021
includes the changes from openshift/installer#4638
abhinavdahiya
added a commit
to abhinavdahiya/hive
that referenced
this pull request
Feb 9, 2021
dc89529 removed passing clientOpts to generate the machinesets as it was dropped as supported option in the installer libraries. since openshift/installer#4638 has re enabled the option and reverting the change in openstackactuator to use the configure client opts for correctly authenticating with openstack apis.
abhinavdahiya
added a commit
to abhinavdahiya/hive
that referenced
this pull request
Feb 9, 2021
dc89529 removed passing clientOpts to generate the machinesets as it was dropped as supported option in the installer libraries. since openshift/installer#4638 has re enabled the option and reverting the change in openstackactuator to use the configure client opts for correctly authenticating with openstack apis.
Contributor
Author
|
/retest |
Contributor
Author
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
/skip |
Contributor
|
@abhinavdahiya: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/skip |
abhinavdahiya
added a commit
to abhinavdahiya/hive
that referenced
this pull request
Feb 11, 2021
includes the changes from openshift/installer#4638
abhinavdahiya
added a commit
to abhinavdahiya/hive
that referenced
this pull request
Feb 11, 2021
dc89529 removed passing clientOpts to generate the machinesets as it was dropped as supported option in the installer libraries. since openshift/installer#4638 has re enabled the option and reverting the change in openstackactuator to use the configure client opts for correctly authenticating with openstack apis.
This was referenced Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 05453ef the MachineSets function was updated to remove the option
to specify external clientOpts. This clientOpts is used by hive to generate
the machinesets and ensuring the correct client authentication is used.
using the default client opts as forced in 05453ef only allows configuring the
openstack client using the default location on the host, which doesn't sit well
with something like hive which needs to manage the machinesets for many different
clients from single location.
Reverting the change in 05453ef to allow machinesets to accept external clientOpts
and use the default opts when it is nil.
xref: https://issues.redhat.com/browse/HIVE-1372
/assign @Fedosin