Skip to content

I bip #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eranco74 wants to merge 4 commits into from
Closed

I bip #4461

eranco74 wants to merge 4 commits into from

Conversation

@eranco74
Copy link
Contributor

@eranco74 eranco74 commented Dec 8, 2020 •
edited
Loading

/hold
Pending enhancement
This is a POC for installing SNO using live-CD that runs the bootstrap flow and then restart to become the master node.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 8, 2020

@eranco74: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

I bip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 8, 2020

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eranco74 eranco74 force-pushed the iBIP branch 3 times, most recently from 5c62210 to d63d4d3 Compare December 13, 2020 11:46
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 13, 2020

@eranco74: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

I bip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2020
@eranco74 eranco74 force-pushed the iBIP branch 5 times, most recently from f6e892d to eb61441 Compare December 13, 2020 20:05
@openshift-ci-robot openshift-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 13, 2020
@romfreiman romfreiman mentioned this pull request Dec 14, 2020
Merged
@staebler
Copy link
Contributor

staebler commented Dec 14, 2020

/assign

wking
wking reviewed Dec 15, 2020
View reviewed changes
data/data/bootstrap/files/usr/local/bin/bootkube.sh.template Outdated
Copy link
Member

@wking wking Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary whitespace change.

wking
wking reviewed Dec 15, 2020
View reviewed changes
Makefile Outdated
Copy link
Member

@wking wking Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been previous proposals to give the installer a Makefile, but they were rejected as "not all that useful, vs. calling hack/... scripts directly". See discussion in #1317 and links from there to even earlier discussion.

Narrowly for this PR, if there was an installer Makefile and it had single-node-specific recipes like this sno_manifest.yaml copy, I'd expect it to be using a single-node-specific rule name (e.g. generate-single-node-ignition-configs or some such).

Copy link
Contributor Author

@eranco74 eranco74 Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Makefile as it was just used for testing

wking
wking reviewed Dec 15, 2020
View reviewed changes
hack/ssh/key Outdated
Copy link
Member

@wking wking Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have been useful for testing, but I don't think we want to commit a dummy SSH key to the installer repo.

Copy link
Contributor Author

@eranco74 eranco74 Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@eranco74
Added patch.service that try to patch the cluster with overrides for …
b729d8d 
…single node during the installation

Added unmanaged patch to patch.sh
@eranco74
Added utilities for starting a single node
7e13094 
Added template install-config.yaml
@eranco74
Copy link
Contributor Author

eranco74 commented Dec 15, 2020

closing this PR since there is another PR targeting master
#4482

@eranco74 eranco74 closed this Dec 15, 2020
@eranco74
Copy link
Contributor Author

eranco74 commented Dec 15, 2020

Reopening for testing purposes.
No need to review.
/hole

@eranco74 eranco74 reopened this Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2020

@eranco74: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

I bip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 15, 2020
@eranco74
Single Node deployment with bootstrap-in-place
858279c 
Updated bootkube.sh.template
Override cluster-bootstrap to accept bootstrap-in-place
Update master ignition
Added after_reboot.sh for compleating single node installation
Added machineconfig manifest with the after_reboot script and service
@staebler staebler removed their assignment Dec 17, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign crawford after the PR has been reviewed.
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eranco74 eranco74 closed this Jan 14, 2021
@eranco74 eranco74 deleted the iBIP branch January 14, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

@cfergeau cfergeau Awaiting requested review from cfergeau

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eranco74 @openshift-ci-robot @staebler @wking @tsorya