Skip to content

Conversation

@hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Sep 9, 2020

Issues covered by this PR.

Lets not print scary errors like the below

Error: Failed to evict container: "": Failed to find container "etcd-signer" in state: no container with name or ID etcd-signer found: no such container

Instead in error lets just print

Tearing down etcd-signer container

The trap is setup to make sure we try and remove etcd-signer container on error. Which serves its purpose. But after the bootstrap etcd has started lets not restart the signer if bootkube restarts. This way we can ensure signer is not competing with apiserver for ports.

@openshift-ci-robot
Copy link
Contributor

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[wip] bootkube.sh: handle retry of etcd-signer gracefully

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sdodson
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[wip] bootkube.sh: handle retry of etcd-signer gracefully

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws a7d75c8 link /test e2e-aws
ci/prow/e2e-openstack a7d75c8 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 a7d75c8 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-ovirt a7d75c8 link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor Author

Going with full solution #4150

@hexfusion hexfusion closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants