Skip to content

Change default tt0 cidr #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 4, 2018
Merged

Change default tt0 cidr #410

openshift-merge-robot merged 1 commit into from
Oct 4, 2018

Conversation

@michaelgugino
Copy link
Contributor

@michaelgugino michaelgugino commented Oct 3, 2018

Most libvirt installs will already have an interface
utilizing 192.168.124.0/24 network. This commit
updates default cluster cidr to a 192.168.126.0/24

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2018
rajatchopra
rajatchopra approved these changes Oct 3, 2018
View reviewed changes
Copy link

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Anything but 192.168.124.0/24 !

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2018
@mrunalp
Copy link
Member

mrunalp commented Oct 3, 2018

I ran into the same issue. 👍

@mrunalp
Copy link
Member

mrunalp commented Oct 3, 2018

You should also update the libvirt instructions so that they can be copy pasted easily.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Oct 3, 2018 •
edited
Loading

/hold

+1 to updating the docs.

$ git grep 192.168.124.0 origin/master -- docs
origin/master:docs/dev/libvirt-howto.md:The following examples use the default cluster IP range of `192.168.124.0/24` (which is currently not configurable) and a libvirt `default` subnet of `192.168.122.0/24`, which might be different in your configuration.
origin/master:docs/dev/libvirt-howto.md:iptables -I INPUT -p tcp -s 192.168.124.0/24 -d 192.168.122.1 --dport 16509 -j ACCEPT -m comment --comment "Allow insecure libvirt clients"
origin/master:docs/dev/libvirt-howto.md:sudo firewall-cmd --zone=FedoraWorkstation --add-source=192.168.124.0/24

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2018
@michaelgugino
Change default tt0 cidr
30b1ae8 
Most libvirt installs will already have an interface
utilizing 192.168.124.0/24 network.  This commit
updates default cluster cidr to a 192.168.126.0/24
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2018
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Oct 3, 2018

@wking docs updated.

@wking
Copy link
Member

wking commented Oct 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, rajatchopra, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Oct 3, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Oct 4, 2018

/hold

Waiting on #415 to unstick CI.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2018
@wking
Copy link
Member

wking commented Oct 4, 2018

#415 is in.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2018
@wking
Copy link
Member

wking commented Oct 4, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit f91e028 into openshift:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

1 more reviewer

@rajatchopra rajatchopra rajatchopra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@rajatchopra rajatchopra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@michaelgugino @mrunalp @openshift-bot @wking @openshift-ci-robot @rajatchopra @openshift-merge-robot