Skip to content

[FCOS] Remove unused bootstrap etcd cert generation mechanism #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 1 commit into from
Closed

[FCOS] Remove unused bootstrap etcd cert generation mechanism #4017

vrutkovs wants to merge 1 commit into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Aug 6, 2020 •
edited
Loading

Cherry-pick of #3995. This is required to unblock release-4.6 in master, after CEO has deprecated a few fields. Hopefully this would work in 4.5 as well

@ironcladlou
Remove unused bootstrap etcd cert generation mechanism
6a71251 
The cluster-etcd-operator render command now handles bootstrap certificate
generation[1]. This patch deletes the now unused client/server bootstrap etcd
cert generation logic.

[1] openshift/cluster-etcd-operator#412
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vrutkovs
You can assign the PR to them by writing /assign @vrutkovs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2020

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 6a71251 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 6, 2020

/hold

This won't work on 4.5

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 6, 2020

This breaks 4.5 :(

@vrutkovs vrutkovs closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @openshift-ci-robot @ironcladlou