OpenStack: Document the MachineSet resource

[pierreprinetti]

Add an example MachineSet with the OpenStack platform-specific
properties.

/label platform/openstack

CC: @maxwelldb

[pierreprinetti]

/cc @Fedosin

[iamemilio]

Adding this is a good idea. What do you think about documenting the fields like we do in the customization docs?

[pierreprinetti]

@iamemilio

documenting the fields

Is it OK if we do that next time?

[iamemilio]

Yeah sure

[iamemilio]

Lgtm, however I think you should add a link to https://github.com/openshift/cluster-api-provider-openstack/blob/master/pkg/apis/openstackproviderconfig/v1alpha1/types.go in a mean time so that users can see the full interface available to them

[pierreprinetti]

@iamemilio

you should add a link

Good idea! Added. PTAL

[openshift-ci-robot]

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	cdbdf51	link	/test e2e-crc
ci/prow/e2e-metal-ipi	cdbdf51	link	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pierreprinetti]

/cc iamemilio

[iamemilio]

/lgtm

[iamemilio]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• docs/user/openstack/OWNERS [iamemilio]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mandre]

This example should probably be added to downstream docs at https://docs.openshift.com/container-platform/4.5/machine_management/creating-infrastructure-machinesets.html#creating-infrastructure-machinesets-clouds, cc @maxwelldb

[pierreprinetti]

@mandre

This example should probably be added to downstream docs

We do have an example published as a generic MachineSet
https://docs.openshift.com/container-platform/4.5/machine_management/creating_machinesets/creating-machineset-osp.html

[maxwelldb]

Yeah, that's already there, and the source file is OSP-specific. Feel free to make a PR against the docs repo (or just ask me) if you'd like to see changes to it.