installer/pkg/workflow/utils: Format quoted paths with %q #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unlikely that base contains single quotes, so this is just a nit. But since %q [1] gives us more robust quoting with fewer source-code characters, it seems like a worthwhile change. [1]: https://golang.org/pkg/fmt/#hdr-Printing
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
needs-ok-to-test
Contributor
|
There may not be quotes but there could be spaces in the path in which case this makes reading the path more obvious. |
Contributor
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
Contributor
|
/lgtm |
squat
approved these changes
Jul 9, 2018
Member
Author
The previous code had |
Member
Author
|
The e2e-aws errors look like these. |
Contributor
|
/retest |
Member
Author
|
Same failures in the most recent run. |
Contributor
|
/retest |
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Add Owns(Secret, Deployment and ClusterOperator) to be watched
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Aug 10, 2021
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unlikely that
basecontains single quotes, so this is just a nit. But since%qgives us more robust quoting with fewer source-code characters, it seems like a worthwhile change.