Add cluster profile parameter in install-config.yaml

[guillaumerose]

Implementation of openshift/enhancements#200
Installer counterpart of openshift/cluster-version-operator#404

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

1. I do not think the profile should be a free-flowing string rather it should be a specific enum

2. I do not want to add this to the install config for all our users and only available using the create manifests and editing the clusterversion API as we get more data around users and usecases we can think about bumping up into the API

[wking]

...as we get more data around users and usecases we can think about bumping up into the API...

Where does this data come from before it goes in the ClusterVersion API? Do you recommend adding it as a label to an existing Telemetry metric or...?

[wking]

I do not want to add this to the install config for all our users and only available using the create manifests...

Which manifest would this belong to? A new manifest/asset just to hold the new value? Alternatively, could we configure this via an embarrassing, unadvertised environment variable like _ALPHA_EXPERIMENTAL_CLUSTER_PROFILE so CRC folks can kick the tires without having a day-0 CVO that tries to install the default profile manifests they'd like to exclude?

[openshift-ci-robot]

@guillaumerose: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/unit	0bbdbc3	link	/test unit
ci/prow/e2e-aws-fips	0bbdbc3	link	/test e2e-aws-fips
ci/prow/e2e-aws	0bbdbc3	link	/test e2e-aws
ci/prow/e2e-libvirt	0bbdbc3	link	/test e2e-libvirt
ci/prow/e2e-ovirt	0bbdbc3	link	/test e2e-ovirt
ci/prow/e2e-metal-ipi	0bbdbc3	link	/test e2e-metal-ipi
ci/prow/e2e-aws-scaleup-rhel7	0bbdbc3	link	/test e2e-aws-scaleup-rhel7
ci/prow/e2e-openstack	0bbdbc3	link	/test e2e-openstack
ci/prow/e2e-crc	0bbdbc3	link	/test e2e-crc
ci/prow/e2e-aws-workers-rhel7	0bbdbc3	link	/test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abhinavdahiya]

Closing this as it has stalled for very long. Please feel free to re-open in case you intent to keep working on it, or consider tracking the work in an issue if this requires agreement for implementation.

/close

[openshift-ci-robot]

@abhinavdahiya: Closed this PR.

Details

In response to this:

Closing this as it has stalled for very long. Please feel free to re-open in case you intent to keep working on it, or consider tracking the work in an issue if this requires agreement for implementation.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eranco74]

The CVO render gets cluster-profile parameter?
I thought it get it as env - openshift/cluster-version-operator#483 (comment)