hack/build: Drop GOPATH stuffing

[wking]

I'd added this in f230c3e (#340), citing golang/go#20406. But:

• vendor/ is not a useful GOPATH addition, because it lacks the src/ that Go requires. Go might look in vendor/src/github.com/... with our GOPATH stuffing, but that won't help it find our vendored
  libraries.

• All that really seems to matter is whether the repository as a whole is checked out into your GOPATH. I'm not sure how to square that with vendor folder ignore on run golang/go#20406.

I'm really looking forward to Go 1.11's modules killing the GOPATH idea.

Reported by @justaugustus.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

@wking this also needs to include a note in the instructions that we need to go get the repo, as opposed to cloning it.

[justaugustus]

/hold

[wking]

this also needs to include a note in the instructions that we need to go get the repo, as opposed to cloning it.

Isn't that generally how Go projects work? Anyhow, I've pushed 511d733 -> 6d8dcb4 with a small note; if you want more detail, maybe file a PR with the working you want to see?

[wking]

e2e:

Waiting for API at https://ci-op-4zqxz8xb-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Another process exited
2018/10/03 01:41:06 Container test in pod e2e-aws failed, exit code 1, reason Error

/retest

[wking]

e2e:

2018/10/03 01:47:47 Executing template e2e-aws
2018/10/03 01:47:47 Creating or restarting template instance
2018/10/03 01:47:47 Waiting for template instance e2e-aws to be deleted ...
E1003 01:47:49.888501 11 event.go:200] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".1559f609d91bc1d7", GenerateName:"", Namespace:"ci-op-4zqxz8xb", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-4zqxz8xb", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-installer-master-e2e-aws for PR https://github.com/openshift/installer/pull/396 in namespace ci-op-4zqxz8xb from author wking", Source:v1.EventSource{Component:"ci-op-4zqxz8xb", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbee525d174884fd7, ext:3565360685, loc:(*time.Location)(0x196f3e0)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbee525d174884fd7, ext:3565360685, loc:(*time.Location)(0x196f3e0)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events ".1559f609d91bc1d7" is forbidden: unable to create new content in namespace ci-op-4zqxz8xb because it is being terminated' (will not retry!)
2018/10/03 01:47:50 Ran for 4s
error: could not run steps: could not create or restart template instance: unable to create template instance: templateinstances.template.openshift.io "e2e-aws" is forbidden: unable to create new content in namespace ci-op-4zqxz8xb because it is being terminated

/retest

[abhinavdahiya]

@wking it seems like #397 has this change.

[wking]

Oops, yeah.